Sign upLogin

simonmittag/jabba

View on GitHub
Star
websockethandler.go

Summary

Maintainability
A
45 mins
Test Coverage
F
45%

Function upgradeWebsocket has 78 lines of code (exceeds 50 allowed). Consider refactoring.
Wontfix

func upgradeWebsocket(proxy *Proxy) {
    var status = make(chan WebsocketStatus)
    var tx *WebsocketTx = &WebsocketTx{}

    //dialer uses TLSInsecureSkipVerify to accept any certificate or host name.
Severity: Major
Found in websockethandler.go - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Wontfix

            } else if isProtocolError(conStat.DwnExit) {
            ev.Msgf(dwnWebSocketProtocolError, conStat.DwnExit)
        } else {
            ev.Msgf(dwnWebsocketUnspecifiedNetworkEvent, conStat.DwnExit.Error())
        }
    Severity: Major
    Found in websockethandler.go - About 45 mins to fix

      Function upgradeWebsocket has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
      Confirmed

      func upgradeWebsocket(proxy *Proxy) {
    var status = make(chan WebsocketStatus)
    var tx *WebsocketTx = &WebsocketTx{}

    //dialer uses TLSInsecureSkipVerify to accept any certificate or host name.
      Severity: Minor
      Found in websockethandler.go - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Wontfix

              } else if isProtocolError(conStat.UpExit) {
            ev.Msgf(upWebSocketProtocolError, conStat.UpExit)
        } else {
            ev.Msgf(upWebsocketUnspecifiedNetworkEvent, conStat.UpExit.Error())
        }
      Severity: Major
      Found in websockethandler.go - About 45 mins to fix

        Function readUpWebsocket has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Wontfix

        func readUpWebsocket(dwnCon net.Conn, upCon net.Conn, proxy *Proxy, status chan<- WebsocketStatus, tx *WebsocketTx) {
        Severity: Minor
        Found in websockethandler.go - About 35 mins to fix

          Function readDwnWebsocket has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Wontfix

          func readDwnWebsocket(dwnCon net.Conn, upCon net.Conn, proxy *Proxy, status chan<- WebsocketStatus, tx *WebsocketTx) {
          Severity: Minor
          Found in websockethandler.go - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

            func readUpWebsocket(dwnCon net.Conn, upCon net.Conn, proxy *Proxy, status chan<- WebsocketStatus, tx *WebsocketTx) {
ReadUp:
    for {
        upCon.SetDeadline(time.Now().Add(time.Second * time.Duration(Runner.Connection.Upstream.IdleTimeoutSeconds)))
        msg, op, ure := wsutil.ReadServerData(upCon)
            Severity: Major
            Found in websockethandler.go and 1 other location - About 6 hrs to fix
            websockethandler.go on lines 261..297

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 461.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

            func readDwnWebsocket(dwnCon net.Conn, upCon net.Conn, proxy *Proxy, status chan<- WebsocketStatus, tx *WebsocketTx) {
ReadDwn:
    for {
        dwnCon.SetDeadline(time.Now().Add(time.Second * time.Duration(Runner.Connection.Downstream.IdleTimeoutSeconds)))
        msg, op, dre := wsutil.ReadClientData(dwnCon)
            Severity: Major
            Found in websockethandler.go and 1 other location - About 6 hrs to fix
            websockethandler.go on lines 299..336

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 461.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                if conStat.UpExit != nil {
        if isTimeout(conStat.UpExit) {
            ev.Msgf(upWebsocketTimeoutFired, Runner.Connection.Upstream.IdleTimeoutSeconds)
        } else if isHangup(conStat.UpExit) {
            ev.Msg(upWebSocketHangup)
            Severity: Major
            Found in websockethandler.go and 1 other location - About 1 hr to fix
            websockethandler.go on lines 231..243

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 160.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                if conStat.DwnExit != nil {
        if isTimeout(conStat.DwnExit) {
            ev.Msgf(dwnWebsocketTimeoutFired, Runner.Connection.Downstream.IdleTimeoutSeconds)
        } else if isHangup(conStat.DwnExit) {
            ev.Msg(dwnWebSocketHangup)
            Severity: Major
            Found in websockethandler.go and 1 other location - About 1 hr to fix
            websockethandler.go on lines 218..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 160.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status