simplay/bofrev

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @main_frame.add_mouse_listener MouseListener.impl { |name, event|
      # key_debugger("MouseListener", name, event)
      offsets = GameSettings.canvas_offsets
      x = event.getX-offsets[0]/2
      y = event.getY-offsets[1]/2

Found in src/view.rb and 1 other location - About 55 mins to fix

Read up
Read up

src/view.rb on lines 43..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Method `draw_rectangle_at` has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def draw_rectangle_at(g, x0, y0, x1, y1, color)

Found in demos/fractals/fractal.rb - About 45 mins to fix

Method `draw_rectangle_at` has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def draw_rectangle_at(g, x0, y0, x1, y1, color)

Found in src/game_field.rb - About 45 mins to fix

Method `draw_rectangle_for` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def draw_rectangle_for(canvas, x0, y0, x1, y1)

Found in src/drawables/quadratic_hull_shape.rb - About 35 mins to fix

Method `transform_pixel_to_range` has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def transform_pixel_to_range(min_a, max_a, min_e, max_e, x)

Found in demos/fractals/fractal.rb - About 35 mins to fix

Method `update_height_lvl` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def update_height_lvl
    @mutex.synchronize do
      if (@current_height_lvl <= JUMP_STEP_HEIGHT) && !@top_reached
        @current_height_lvl = @current_height_lvl + 1
        @gestalt.translate_by(Point2f.new(@steps_to_walk, -JUMP_STEP_HEIGHT))

Found in src/game_player.rb - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `draw_fractal_pixel_at` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def draw_fractal_pixel_at(graphics, p_x, p_y, zoom_lvl)
    # transform pixel coordinates to normalized coordinates
    sq_zoom_lvl = Math.sqrt(zoom_lvl)
    zoomed_x_min = -2.5 / sq_zoom_lvl
    zoomed_x_max = 1.0 / sq_zoom_lvl

Found in demos/fractals/fractal.rb - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `process_event` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def process_event(message)
    case message.type
    when D_KEY
      @shape.move_by(Point2f.new(1,0), :move_sidewards)
    when A_KEY

Found in demos/tetris/tetris_map.rb - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `handle_update` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def handle_update(new_pp, pp, del)

    if hist_chest?(new_pp)
      unless hit_wall?(Point2f.new(@chest.value.x+del.x, @chest.value.y+del.y))
        set_entities(@chest.value.x+del.x, @chest.value.y+del.y)

Found in demos/sokoban/sokoban_map.rb - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `to_i` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def to_i
    if border?
      2
    elsif floor?
      3

Found in src/game_field.rb - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading