Showing 33 of 33 total issues
File SimplelocalizeCliCommand.java
has 475 lines of code (exceeds 250 allowed). Consider refactoring. Open
package io.simplelocalize.cli;
import io.simplelocalize.cli.client.SimpleLocalizeClient;
import io.simplelocalize.cli.client.dto.proxy.AutoTranslationConfiguration;
import io.simplelocalize.cli.client.dto.proxy.Configuration;
Method invoke
has 85 lines of code (exceeds 25 allowed). Consider refactoring. Open
public void invoke() throws IOException, InterruptedException
{
configurationValidator.validateUploadConfiguration(configuration);
String uploadPath = configuration.getUploadPath();
boolean isDryRun = Boolean.TRUE.equals(configuration.getDryRun());
Method invoke
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
public void invoke() throws IOException, InterruptedException
{
configurationValidator.validateUploadConfiguration(configuration);
String uploadPath = configuration.getUploadPath();
boolean isDryRun = Boolean.TRUE.equals(configuration.getDryRun());
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method upload
has 61 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Command(
name = "upload",
description = "Upload translations or translation keys to SimpleLocalize editor. Use 'simplelocalize upload --help' to learn more about the parameters.")
public void upload(
@Option(names = {"--apiKey"}, description = "Project API Key") String apiKey,
Method invoke
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
public void invoke() throws IOException, InterruptedException
{
String downloadPath = configuration.getDownloadPath();
String downloadFormat = configuration.getDownloadFormat();
String languageKey = configuration.getLanguageKey();
Method getHttpProxyValueOrNull
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static ProxyConfiguration getHttpProxyValueOrNull(String httpProxyValue)
{
if (httpProxyValue == null || httpProxyValue.isEmpty())
{
return null;
Method download
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Command(
name = "download",
description = "Download translations in ready to use format for your i18n library. Use 'simplelocalize download --help' to learn more about the parameters.")
public void download(
@Option(names = {"--apiKey"}, description = "Project API Key") String apiKey,
Method invoke
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public void invoke() throws IOException, InterruptedException
{
String responseData = client.fetchProject();
DocumentContext json = jsonReader.read(responseData);
Similar blocks of code found in 2 locations. Consider refactoring. Open
package io.simplelocalize.cli.extraction.processor;
import io.simplelocalize.cli.extraction.ExtractionResult;
import io.simplelocalize.cli.extraction.files.BaseExtensionFilesFinder;
import io.simplelocalize.cli.extraction.files.JavaScriptAndTypeScriptFilesFinder;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 95.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
package io.simplelocalize.cli.extraction.processor;
import io.simplelocalize.cli.extraction.ExtractionResult;
import io.simplelocalize.cli.extraction.files.BaseExtensionFilesFinder;
import io.simplelocalize.cli.extraction.files.JavaScriptAndTypeScriptFilesFinder;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 95.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method upload
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
@Command(
name = "upload",
description = "Upload translations or translation keys to SimpleLocalize editor. Use 'simplelocalize upload --help' to learn more about the parameters.")
public void upload(
@Option(names = {"--apiKey"}, description = "Project API Key") String apiKey,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sync
has 11 arguments (exceeds 4 allowed). Consider refactoring. Open
@Option(names = {"--apiKey"}, description = "Project API Key") String apiKey,
@Option(names = {"--uploadPath"}, description = "Path to file with translation or translation keys to upload. Use '{lang}' to define language key if you are uploading more than one file with translations.") String uploadPath,
@Option(names = {"--uploadFormat"}, description = "Translations file format") String uploadFormat,
@Option(names = {"--uploadOptions"}, split = ",", description = "(Optional) Upload options") List<String> uploadOptions,
@Option(names = {"--downloadPath"}, description = "Directory where translations should be downloaded") String downloadPath,
Method pull
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Command(
name = "pull",
description = "Pull translations from Translation Hosting Use 'simplelocalize pull --help' to learn more about the parameters.")
public void pull(
@Option(names = {"--apiKey"}, description = "Project API Key") String apiKey,
Method getHttpProxyValueOrNull
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
public static ProxyConfiguration getHttpProxyValueOrNull(String httpProxyValue)
{
if (httpProxyValue == null || httpProxyValue.isEmpty())
{
return null;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method upload
has 10 arguments (exceeds 4 allowed). Consider refactoring. Open
@Option(names = {"--apiKey"}, description = "Project API Key") String apiKey,
@Option(names = {"--uploadPath"}, description = "Path to file with translation or translation keys to upload. Use '{lang}' to define language key if you are uploading more than one file with translations.") String uploadPath,
@Option(names = {"--uploadFormat"}, description = "Translations file format") String uploadFormat,
@Option(names = {"--overwrite"}, description = "(Optional) Overwrite existing translations", defaultValue = "false") Boolean overwrite,
@Option(names = {"--delete"}, description = "(Optional) Delete translations which are not present in uploaded file", defaultValue = "false") Boolean delete,
Method invoke
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public void invoke() throws IOException, InterruptedException
{
int runningJobsCount = getRunningJobsCount();
while (runningJobsCount > 0)
{
Method autoTranslate
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
@Command(
name = "auto-translate",
description = "Start auto-translation. 'simplelocalize auto-translate --help' to learn more about the parameters.")
public void autoTranslate(
@Option(names = {"--apiKey"}, description = "Project API Key") String apiKey,
Method buildDownloadUri
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
URI buildDownloadUri(DownloadRequest downloadRequest)
{
String endpointUrl = baseUrl + "/cli/v2/download?downloadFormat=" + downloadRequest.format();
String languageKey = downloadRequest.languageKey();
boolean isRequestedTranslationsForSpecificLanguage = StringUtils.isNotEmpty(languageKey);
Method invoke
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public void invoke() throws IOException, InterruptedException
{
String downloadPath = configuration.getDownloadPath();
String downloadFormat = configuration.getDownloadFormat();
String languageKey = configuration.getLanguageKey();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method download
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
@Command(
name = "download",
description = "Download translations in ready to use format for your i18n library. Use 'simplelocalize download --help' to learn more about the parameters.")
public void download(
@Option(names = {"--apiKey"}, description = "Project API Key") String apiKey,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"