Sign upLogin

sirfoga/pyhal

View on GitHub
Star
hal/maths/nt/primes.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function test_miller_rabin has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def test_miller_rabin(self, precision):
        """Tests prime with miller-rabin algorithm

        :param precision: number of rounds to perform
        :return: True iff probably prime
Severity: Minor
Found in hal/maths/nt/primes.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if i == t - 1:
                            return False
                        else:
                            i += 1
                            v = (v ** 2) % self.to_int
Severity: Major
Found in hal/maths/nt/primes.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status