Sign upLogin

siruku6/fx_alarm_py

View on GitHub
Star
src/history_visualizer.py

Summary

Maintainability
B
5 hrs
Test Coverage
F
59%

File history_visualizer.py has 292 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import datetime
from datetime import timedelta
from typing import List, Optional, Tuple, TypedDict

from oanda_accessor_pyv20 import OandaInterface
Severity: Minor
Found in src/history_visualizer.py - About 3 hrs to fix

    Visualizer has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Visualizer:
    DRAWABLE_ROWS = 200

    def __init__(
        self,
    Severity: Minor
    Found in src/history_visualizer.py - About 2 hrs to fix

      Cyclomatic complexity is too high in method __adjust_time_for_merging. (7)
      Open

          def __adjust_time_for_merging(
        self, candles: pd.DataFrame, history_df: pd.DataFrame, granularity: str
    ) -> pd.DataFrame:
        dict_dst_switches: List[DstSwitch] = None
        if granularity in ("H4",) and len(history_df) > 0:
      Severity: Minor
      Found in src/history_visualizer.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      There are no issues that match your filters.

      Category
      Status