siruku6/fx_alarm_py

View on GitHub
src/trade_rules/wait_close.py

Summary

Maintainability
A
35 mins
Test Coverage

Function thrusting_exist has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def thrusting_exist(trend, two_before_high, previous_high, two_before_low, previous_low):
Severity: Minor
Found in src/trade_rules/wait_close.py - About 35 mins to fix

    Remove this commented out code.
    Open

    # def the_previous_satisfy_rules(preconditions):
    Severity: Major
    Found in src/trade_rules/wait_close.py by sonar-python

    Programmers should not comment out code as it bloats programs and reduces readability.

    Unused code should be deleted and can be retrieved from source control history if required.

    See

    • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
    • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
    • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
    • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

    There are no issues that match your filters.

    Category
    Status