Sign upLogin

sitch-io/sensor

View on GitHub
Star
sitch/sitchlib/feed_manager.py

Summary

Maintainability
C
1 day
Test Coverage

File feed_manager.py has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Feed Manager."""

import csv
import dateutil
import gzip
Severity: Minor
Found in sitch/sitchlib/feed_manager.py - About 4 hrs to fix

    Function dump_csv_to_db has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def dump_csv_to_db(cls, db_schema, db_translate_schema, feed_file, db_file,
                       target_radios, last_upd=0):
        """Merge CSV into DB, taking into account the record update time.

        Args:
    Severity: Minor
    Found in sitch/sitchlib/feed_manager.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function dump_csv_to_db has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def dump_csv_to_db(cls, db_schema, db_translate_schema, feed_file, db_file,
    Severity: Minor
    Found in sitch/sitchlib/feed_manager.py - About 45 mins to fix

      Function reconcile_db has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def reconcile_db(cls, db_schema, db_translate_schema, feed_files, db_file,
      Severity: Minor
      Found in sitch/sitchlib/feed_manager.py - About 45 mins to fix

        Function merge_feed_files_into_db has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def merge_feed_files_into_db(cls, db_schema, db_translate_schema,
        Severity: Minor
        Found in sitch/sitchlib/feed_manager.py - About 45 mins to fix

          Function create_and_populate_db has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def create_and_populate_db(cls, db_schema, db_translate_schema, feed_files,
          Severity: Minor
          Found in sitch/sitchlib/feed_manager.py - About 35 mins to fix

            Function merge_feed_files_into_db has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def merge_feed_files_into_db(cls, db_schema, db_translate_schema,
                                 feed_files, db_file, target_radios, last_upd):
        """Wrapper for merging feed file data into CGI DB.

        Args:
            Severity: Minor
            Found in sitch/sitchlib/feed_manager.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function create_and_populate_db has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def create_and_populate_db(cls, db_schema, db_translate_schema, feed_files,
                               db_file, target_radios):
        """Create DB, then merge all records from file.

        Args:
            Severity: Minor
            Found in sitch/sitchlib/feed_manager.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Error: Missing parentheses in call to 'print'. Did you mean print(print msg)? (<unknown>, line 273)</unknown>
            Open

                                print msg
            Severity: Minor
            Found in sitch/sitchlib/feed_manager.py by radon

            We encountered an error attempting to analyze this line.

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    for feed_id in self.state_list:
            feed_file = FeedManager.place_feed_file(self.feed_dir,
                                                    self.url_base,
                                                    feed_id)
            self.arfcn_feed_files.append(feed_file)
            Severity: Minor
            Found in sitch/sitchlib/feed_manager.py and 1 other location - About 50 mins to fix
            sitch/sitchlib/feed_manager.py on lines 56..60

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    for feed_id in self.mcc_list:
            feed_file = FeedManager.place_feed_file(self.feed_dir,
                                                    self.url_base,
                                                    feed_id)
            self.cgi_feed_files.append(feed_file)
            Severity: Minor
            Found in sitch/sitchlib/feed_manager.py and 1 other location - About 50 mins to fix
            sitch/sitchlib/feed_manager.py on lines 61..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status