Sign upLogin

sjansen/mecha

View on GitHub
Star

Showing 13 of 13 total issues

Method stdview.init has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
Open

func (v *stdview) init(app *tview.Application, label string, stdout, stderr <-chan string, updates <-chan *Status) {
    view := tview.NewTextView()
    v.TextView = view
    v.app = app
Severity: Minor
Found in internal/tui/stdview.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func main() {
    if exists, err := exists(pytest); err != nil {
        die(err)
    } else if !exists {
        fmt.Fprintln(os.Stderr, "No such file:", pytest)
Severity: Minor
Found in spikes/pytest/main.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    app.SetInputCapture(func(e *tcell.EventKey) *tcell.EventKey {
        key := e.Key()
        switch {
        case key == tcell.KeyTab:
            screen.focusNext()
Severity: Major
Found in internal/tui/stacked.go and 1 other location - About 1 hr to fix
internal/tui/tui.go on lines 55..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    app.SetInputCapture(func(e *tcell.EventKey) *tcell.EventKey {
        key := e.Key()
        switch {
        case key == tcell.KeyTab:
            screen.focusNext()
Severity: Major
Found in internal/tui/tui.go and 1 other location - About 1 hr to fix
internal/tui/stacked.go on lines 30..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function main has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func main() {
    opts := &syntax.FileOptions{
        Set: true,
    }
Severity: Minor
Found in spikes/repl/main.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has 63 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    opts := &syntax.FileOptions{
        Set: true,
    }
Severity: Minor
Found in spikes/repl/main.go - About 1 hr to fix

    Function main has 61 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func main() {
    if exists, err := exists(pytest); err != nil {
        die(err)
    } else if !exists {
        fmt.Fprintln(os.Stderr, "No such file:", pytest)
    Severity: Minor
    Found in spikes/pytest/main.go - About 1 hr to fix

      Method DemoScreen.AddStreamPair has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
      Open

      func (s *DemoScreen) AddStreamPair(title string, stdout, stderr <-chan string) {
    view := tview.NewTextView().
        SetDynamicColors(true)
    view.SetBorder(true).
        SetTitle(title).
      Severity: Minor
      Found in internal/tui/tui.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function main has 58 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func main() {
    ctx := context.Background()
    cli, err := client.NewClientWithOpts(client.FromEnv)
    if err != nil {
        panic(err)
      Severity: Minor
      Found in spikes/docker-run/main.go - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if x, err := mem.VirtualMemory(); err != nil {
                update.Severity = tui.Unknown
                update.Message = "???"
            } else {
                var status string
        Severity: Major
        Found in internal/commands/start.go and 1 other location - About 1 hr to fix
        internal/commands/start.go on lines 104..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 145.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if x, err := disk.Usage(root); err != nil {
                update.Severity = tui.Unknown
                update.Message = "???"
            } else {
                var status string
        Severity: Major
        Found in internal/commands/start.go and 1 other location - About 1 hr to fix
        internal/commands/start.go on lines 139..161

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 145.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method stdview.init has 53 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (v *stdview) init(app *tview.Application, label string, stdout, stderr <-chan string, updates <-chan *Status) {
    view := tview.NewTextView()
    v.TextView = view
    v.app = app
        Severity: Minor
        Found in internal/tui/stdview.go - About 1 hr to fix

          Function search has 5 return statements (exceeds 4 allowed).
          Open

          func search(head *object.Commit, path string, target plumbing.Hash) (*object.Commit, error) {
    seen := map[plumbing.Hash]struct{}{
        head.Hash: {},
    }
    stack := []*object.Commit{head}
          Severity: Major
          Found in spikes/git/main.go - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language