Sign upLogin

sjsucohort6/amigo-chatbot

View on GitHub
Star
chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java

Summary

Maintainability
A
1 hr
Test Coverage

Method sendMessage has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @POST
    @Produces(MediaType.APPLICATION_JSON)
    @Consumes(MediaType.APPLICATION_JSON)
    public Response sendMessage(String messageJson) {
        try {
Severity: Minor
Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                } catch (Exception e) {
                log.log(Level.SEVERE, "Error in processing message", e);
                return Response.status(Response.Status.BAD_REQUEST).entity(Entity.text("Error in processing message: " + e.getMessage())).build();
            }
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java and 1 other location - About 35 mins to fix
    riabot-service/src/main/java/edu/sjsu/amigo/riabot/rest/RiaResource.java on lines 59..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Wrong lexicographical order for 'java.util.UUID' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import java.util.UUID;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 115).
    Open

                    JobManager.getInstance().scheduleJob(ChatbotMessageProcessorJob.class, jobName, groupName, params);
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Extra separation in import group before 'edu.sjsu.amigo.scheduler.jobs.JobConstants.JOB_PARAM_MESSAGE'
    Open

    import static edu.sjsu.amigo.scheduler.jobs.JobConstants.JOB_PARAM_MESSAGE;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'javax.ws.rs.client.Entity' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import javax.ws.rs.client.Entity;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.io.IOException' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import java.io.IOException;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'javax.ws.rs.core.MediaType' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import javax.ws.rs.core.MediaType;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'javax.ws.rs.core.Response' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import javax.ws.rs.core.Response;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 107).
    Open

     * Chatbot resource endpoint. This is used to send messages coming from various client types (slack or RIA)
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'java.util.logging.Level' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import java.util.logging.Level;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 146).
    Open

                    return Response.status(Response.Status.BAD_REQUEST).entity(Entity.text("Error in processing message: " + e.getMessage())).build();
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'edu.sjsu.amigo.scheduler.jobs.JobConstants.JOB_PARAM_MESSAGE' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import static edu.sjsu.amigo.scheduler.jobs.JobConstants.JOB_PARAM_MESSAGE;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'javax.ws.rs.Consumes' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import javax.ws.rs.Consumes;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 116).
    Open

                    return Response.status(Response.Status.BAD_REQUEST).entity(Entity.text("unknown bot type")).build();
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'javax.ws.rs.POST' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import javax.ws.rs.POST;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'javax.ws.rs.Path' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import javax.ws.rs.Path;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Wrong lexicographical order for 'javax.ws.rs.Produces' import. Should be before 'org.quartz.JobDataMap'.
    Open

    import javax.ws.rs.Produces;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Extra separation in import group before 'javax.ws.rs.Consumes'
    Open

    import javax.ws.rs.Consumes;
    Severity: Minor
    Found in chatbot-service/src/main/java/edu/sjsu/amigo/chatbot/rest/ChatResource.java by checkstyle

    Checks that the groups of import declarations appear in the order specifiedby the user. If there is an import but its group is not specified in theconfiguration such an import should be placed at the end of the import list.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    There are no issues that match your filters.

    Category
    Status