Sign upLogin

skandragon/thing

View on GitHub
Star
app/controllers/admin/reports_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method render_pdf has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def render_pdf
    @pdf = Prawn::Document.new(page_size: 'LETTER', page_layout: :portrait,
      :compress => true, :optimize_objects => true,
      :info => {
        :Title => "Pennsic University #{Pennsic.year} Instructor Signup",
Severity: Minor
Found in app/controllers/admin/reports_controller.rb - About 1 hr to fix

    Method render_pdf has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def render_pdf
    @pdf = Prawn::Document.new(page_size: 'LETTER', page_layout: :portrait,
      :compress => true, :optimize_objects => true,
      :info => {
        :Title => "Pennsic University #{Pennsic.year} Instructor Signup",
    Severity: Minor
    Found in app/controllers/admin/reports_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method kingdom_war_points has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def kingdom_war_points
    respond_to do |format|

      format.csv {
        ret = CSV.generate do |csv|
    Severity: Minor
    Found in app/controllers/admin/reports_controller.rb - About 1 hr to fix

      Method kingdom_war_points has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def kingdom_war_points
    respond_to do |format|

      format.csv {
        ret = CSV.generate do |csv|
      Severity: Minor
      Found in app/controllers/admin/reports_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method render_instructables has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def render_instructables(instructables)
    instances = Instance.where(instructable_id: instructables.map(&:id)).order(:start_time).includes(:instructable)

    items = instances.map { |instance|
      [
      Severity: Minor
      Found in app/controllers/admin/reports_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  instances.each do |instance|
              instructable = instructables[instance.instructable_id].first
              user = users[instructable.user_id].first

              kingdoms[user.kingdom] += instructable.duration if user.kingdom.present?
      Severity: Minor
      Found in app/controllers/admin/reports_controller.rb and 1 other location - About 20 mins to fix
      bin/kingdom-report.rb on lines 26..30

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status