Sign upLogin

skandragon/thing

View on GitHub
Star
app/lib/calendar_renderer.rb

Summary

Maintainability
F
4 days
Test Coverage

Method render_pdf has a Cognitive Complexity of 64 (exceeds 5 allowed). Consider refactoring.
Open

  def render_pdf(options, filename, cache_filename = nil, user = nil)
    @options = options
    @options = {} if @options.nil?
    @options.reverse_merge!({
      user: nil,
Severity: Minor
Found in app/lib/calendar_renderer.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method render_pdf has 155 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def render_pdf(options, filename, cache_filename = nil, user = nil)
    @options = options
    @options = {} if @options.nil?
    @options.reverse_merge!({
      user: nil,
Severity: Major
Found in app/lib/calendar_renderer.rb - About 6 hrs to fix

    File calendar_renderer.rb has 361 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'csv'

class CalendarRenderer
  include GriffinPdf
  include GriffinMarkdown
    Severity: Minor
    Found in app/lib/calendar_renderer.rb - About 4 hrs to fix

      Method render_ics has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

        def render_ics(options, filename, cache_filename = nil)
    @options = options
    @options = {} if options.nil?
    @options.reverse_merge!({
      calendar_name: "Pennsic #{Pennsic.year} Master Schedule",
      Severity: Minor
      Found in app/lib/calendar_renderer.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method render_topic_list has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

        def render_topic_list(pdf, instructables)
    pdf.move_down 8 unless pdf.cursor == pdf.bounds.top
    pdf.font_size 14
    pdf.text instructables.first.topic
    pdf.font_size PDF_FONT_SIZE
      Severity: Minor
      Found in app/lib/calendar_renderer.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method render_ics has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def render_ics(options, filename, cache_filename = nil)
    @options = options
    @options = {} if options.nil?
    @options.reverse_merge!({
      calendar_name: "Pennsic #{Pennsic.year} Master Schedule",
      Severity: Minor
      Found in app/lib/calendar_renderer.rb - About 1 hr to fix

        Method render_xlsx has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def render_xlsx(options, filename)
    @options = options
    @options = {} if @options.nil?

    p = Axlsx::Package.new
        Severity: Minor
        Found in app/lib/calendar_renderer.rb - About 1 hr to fix

          Method render_topic_list has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def render_topic_list(pdf, instructables)
    pdf.move_down 8 unless pdf.cursor == pdf.bounds.top
    pdf.font_size 14
    pdf.text instructables.first.topic
    pdf.font_size PDF_FONT_SIZE
          Severity: Minor
          Found in app/lib/calendar_renderer.rb - About 1 hr to fix

            Method render_csv has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def render_csv(options, filename)
    @options = options
    @options = {} if @options.nil?

    column_names = %w(
            Severity: Minor
            Found in app/lib/calendar_renderer.rb - About 1 hr to fix

              Method render_csv has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def render_csv(options, filename)
    @options = options
    @options = {} if @options.nil?

    column_names = %w(
              Severity: Minor
              Found in app/lib/calendar_renderer.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method materials_and_handout_content has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def materials_and_handout_content(instructable)
    materials = []
    handout = []
    handout << "limit: #{instructable.handout_limit}" if instructable.handout_limit
    materials << "limit: #{instructable.material_limit}" if instructable.material_limit
              Severity: Minor
              Found in app/lib/calendar_renderer.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                def materials_and_handout_content(instructable)
    materials = []
    handout = []
    handout << "limit: #{instructable.handout_limit}" if instructable.handout_limit
    materials << "limit: #{instructable.material_limit}" if instructable.material_limit
              Severity: Major
              Found in app/lib/calendar_renderer.rb and 1 other location - About 2 hrs to fix
              sched.rb on lines 632..647

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 80.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  pdf.font_families.update(
        'Arial' => {
          normal: Rails.root.join('app', 'assets', 'fonts', 'Arial.ttf'),
          bold: Rails.root.join('app', 'assets', 'fonts', 'Arial Bold.ttf'),
          italic: Rails.root.join('app', 'assets', 'fonts', 'Arial Italic.ttf'),
              Severity: Minor
              Found in app/lib/calendar_renderer.rb and 1 other location - About 40 mins to fix
              app/controllers/coordinator/locations_controller.rb on lines 77..84

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 38.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status