Sign upLogin

skandragon/thing

View on GitHub
Star

Showing 175 of 175 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def send_email_on_create
    user_address = @instructable.user.email
    admin_addresses = User.where(admin: true).pluck(:email)
    admin_addresses -= [user_address]
Severity: Major
Found in app/controllers/instructables_controller.rb and 1 other location - About 1 hr to fix
app/controllers/instructables_controller.rb on lines 133..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if subentries.count > 0
    need_new_page = true
    subentries.sort! { |a, b| a[:start_time].to_i <=> b[:start_time].to_i }
    render_extra(pdf,
                 entries: subentries,
Severity: Major
Found in sched.rb and 1 other location - About 1 hr to fix
sched.rb on lines 804..817

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if subentries.count > 0
    need_new_page = true
    subentries.sort! { |a, b| a[:start_time].to_i <=> b[:start_time].to_i }
    render_extra(pdf,
                 entries: subentries,
Severity: Major
Found in sched.rb and 1 other location - About 1 hr to fix
sched.rb on lines 766..779

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method render_pdf has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def render_pdf
    @pdf = Prawn::Document.new(page_size: 'LETTER', page_layout: :portrait,
      :compress => true, :optimize_objects => true,
      :info => {
        :Title => "Pennsic University #{Pennsic.year} Instructor Signup",
Severity: Minor
Found in app/controllers/admin/reports_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method render has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def render(pdf, opts)
  debug = false

  if debug
    pdf.stroke_axis
Severity: Minor
Found in sched.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method kingdom_war_points has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def kingdom_war_points
    respond_to do |format|

      format.csv {
        ret = CSV.generate do |csv|
Severity: Minor
Found in app/controllers/admin/reports_controller.rb - About 1 hr to fix

    Method render_topic_list has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def render_topic_list(pdf, instructables)
    pdf.move_down 8 unless pdf.cursor == pdf.bounds.top
    pdf.font_size 14
    pdf.text instructables.first.topic
    pdf.font_size PDF_FONT_SIZE
    Severity: Minor
    Found in app/lib/calendar_renderer.rb - About 1 hr to fix

      Function moveMonth has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              moveMonth: function (date, dir) {
            if (!dir) return date;
            var new_date = new Date(date.valueOf()),
                day = new_date.getUTCDate(),
                month = new_date.getUTCMonth(),
      Severity: Minor
      Found in app/assets/javascripts/datetimepicker/bootstrap-datetimepicker.js - About 1 hr to fix

        Method sanitize_changes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.sanitize_changes(list)
    data = JSON::load list.to_json
    keys = data.keys
    keys.each do |key|
      if data[key].is_a?Array
        Severity: Minor
        Found in app/models/changelog.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method draw_location_labels has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        def draw_location_labels(pdf, opts)
  opts[:location_labels].each_with_index do |label, labelindex|
    y1 = @header_height + labelindex * @row_height
    x1 = 0
    y2 = y1 + @row_height - 1
        Severity: Minor
        Found in sched.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (meridian != meridianOld) {
                        if (meridianOld != '') {
                            html.push('</fieldset>');
                        }
                        html.push('<fieldset class="minute"><legend>' + meridian.toUpperCase() + '</legend>');
          Severity: Major
          Found in app/assets/javascripts/datetimepicker/bootstrap-datetimepicker.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/datetimepicker/bootstrap-datetimepicker.js on lines 599..604

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (meridian != meridianOld) {
                        if (meridianOld != '') {
                            html.push('</fieldset>');
                        }
                        html.push('<fieldset class="hour"><legend>' + meridian.toUpperCase() + '</legend>');
          Severity: Major
          Found in app/assets/javascripts/datetimepicker/bootstrap-datetimepicker.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/datetimepicker/bootstrap-datetimepicker.js on lines 630..635

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function place has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  place: function () {
            if (this.isInline) return;

            var index_highest = 0;
            $('div').each(function () {
          Severity: Minor
          Found in app/assets/javascripts/datetimepicker/bootstrap-datetimepicker.js - About 1 hr to fix

            Method check_for_proofread_changes has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def check_for_proofread_changes
    return true if @is_proofreader and @is_proofreader == :no_really

    needs_clearing = false
    changes.keys.each do |field_name|
            Severity: Minor
            Found in app/models/instructable.rb - About 1 hr to fix

              Method index has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def index
    @allowed_tracks = Instructable::TRACKS.keys
    @track = params[:track]

    @proofread = params[:proofread]
              Severity: Minor
              Found in app/controllers/proofreader/instructables_controller.rb - About 1 hr to fix

                Method show has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def show
    render_options = {}

    date = params[:id]
                Severity: Minor
                Found in app/controllers/calendars_controller.rb - About 1 hr to fix

                  Method interesting_change has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def self.interesting_change(change, start_date, end_date)
    action = change[:action]

    ret = []
                  Severity: Minor
                  Found in app/models/changelog.rb - About 1 hr to fix

                    Method changes_for_instances has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      def self.changes_for_instances(original, current)
    original_ids = original.map(&:id)
    current_ids = current.map(&:id)
    ret = []
                    Severity: Minor
                    Found in app/models/changelog.rb - About 1 hr to fix

                      Method recursive_changes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def self.recursive_changes(item)
    new_counter = 0
    changes = item.changes.dup
    nested_names = item.nested_attributes_options.keys
    nested_names.each do |nested_name|
                      Severity: Minor
                      Found in app/models/changelog.rb - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method render_csv has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        def render_csv(options, filename)
    @options = options
    @options = {} if @options.nil?

    column_names = %w(
                      Severity: Minor
                      Found in app/lib/calendar_renderer.rb - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language