skcc321/dumpman

View on GitHub
lib/dumpman/adapters/base.rb

Summary

Maintainability
A
0 mins
Test Coverage
B
87%

Dumpman::Adapters::Base has no descriptive comment
Open

    class Base
Severity: Minor
Found in lib/dumpman/adapters/base.rb by reek

Classes and modules are the units of reuse and release. It is therefore considered good practice to annotate every class and module with a brief comment outlining its responsibilities.

Example

Given

class Dummy
  # Do things...
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [1]:Dummy has no descriptive comment (IrresponsibleModule)

Fixing this is simple - just an explaining comment:

# The Dummy class is responsible for ...
class Dummy
  # Do things...
end

Inconsistent indentation detected.
Open

        def host
          @host ||= db_config.fetch(:host) { 'localhost' }
        end
Severity: Minor
Found in lib/dumpman/adapters/base.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

        def db_config
          @db_config ||= ActiveRecord::Base.connection_config
        end
Severity: Minor
Found in lib/dumpman/adapters/base.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Line is too long. [105/80]
Open

          @password ||= db_config.fetch(:password) { raise("you should set password in 'database.yml'") }
Severity: Minor
Found in lib/dumpman/adapters/base.rb by rubocop

Missing top-level class documentation comment.
Open

    class Base
Severity: Minor
Found in lib/dumpman/adapters/base.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Inconsistent indentation detected.
Open

        def password
          @password ||= db_config.fetch(:password) { raise("you should set password in 'database.yml'") }
        end
Severity: Minor
Found in lib/dumpman/adapters/base.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

        def database
          @database ||= db_config.fetch(:database)
        end
Severity: Minor
Found in lib/dumpman/adapters/base.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

        def username
          @username ||= db_config.fetch(:username) { db_config.fetch(:user) }
        end
Severity: Minor
Found in lib/dumpman/adapters/base.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

There are no issues that match your filters.

Category
Status