Sign upLogin

skqr/hateoas-bundle

View on GitHub
Star

Showing 191 of 191 total issues

Method getRelationAction has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getRelationAction($primaryType, $id, $relationship)
    {
        try {
            $params = $this->get('hateoas.request_parser')->parse($this->getRequest());
        } catch (NotFoundException $e) {
Severity: Minor
Found in Controller/MagicFetchController.php - About 1 hr to fix

    Function linkAction has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function linkAction($primaryType, $id, $relationship, $ids = NULL)
    {
        try {
            $params = $this->get('hateoas.request_parser')
                ->parse($this->getRequest());
    Severity: Minor
    Found in Controller/MagicAlterController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method deleteAction has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function deleteAction($primaryType, $ids)
    {
        try {
            $params = $this->get('hateoas.request_parser')->parse($this->getRequest());
        } catch (NotFoundException $e) {
    Severity: Minor
    Found in Controller/MagicAlterController.php - About 1 hr to fix

      Method getWithFiltersAction has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getWithFiltersAction($primaryType)
    {
        try {
            $params = $this->get('hateoas.request_parser')->parse($this->getRequest());
        } catch (NotFoundException $e) {
      Severity: Minor
      Found in Controller/MagicFetchController.php - About 1 hr to fix

        Method getByIdsAction has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getByIdsAction($primaryType, $ids)
    {
        try {
            $params = $this->get('hateoas.request_parser')->parse($this->getRequest());
        } catch (NotFoundException $e) {
        Severity: Minor
        Found in Controller/MagicFetchController.php - About 1 hr to fix

          Method getFieldAction has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getFieldAction($primaryType, $id, $field)
    {
        try {
            $params = $this->get('hateoas.request_parser')->parse($this->getRequest());
        } catch (NotFoundException $e) {
          Severity: Minor
          Found in Controller/MagicFetchController.php - About 1 hr to fix

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                public function linkAction($primaryType, $id, $relationship, $ids = NULL)
            Severity: Minor
            Found in Controller/MagicAlterController.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $em. Configured minimum length is 3.
            Open

                    $em = $this->getDoctrine()->getManager();
            Severity: Minor
            Found in Controller/MagicAlterController.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                public function getRelationAction($primaryType, $id, $relationship)
            Severity: Minor
            Found in Controller/MagicFetchController.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $em. Configured minimum length is 3.
            Open

                    $em = $this->getDoctrine()->getManager();
            Severity: Minor
            Found in Controller/MagicAlterController.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $em. Configured minimum length is 3.
            Open

                    $em = $this->getDoctrine()->getManager();
            Severity: Minor
            Found in Controller/MagicAlterController.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $em. Configured minimum length is 3.
            Open

                protected static $em;
            Severity: Minor
            Found in Test/PHPUnit/ApiTestCase.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $em. Configured minimum length is 3.
            Open

                    $em = $this->getDoctrine()->getManager();
            Severity: Minor
            Found in Controller/MagicAlterController.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Avoid variables with short names like $id. Configured minimum length is 3.
            Open

                public function getFieldAction($primaryType, $id, $field)
            Severity: Minor
            Found in Controller/MagicFetchController.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

            Source https://phpmd.org/rules/naming.html#shortvariable

            Function deleteAction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function deleteAction($primaryType, $ids)
    {
        try {
            $params = $this->get('hateoas.request_parser')->parse($this->getRequest());
        } catch (NotFoundException $e) {
            Severity: Minor
            Found in Controller/MagicAlterController.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function process has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function process(ContainerBuilder $container)
    {
        foreach (self::$services as $service) {
            $name = $tag = self::SERVICE_PREFIX . $service;
            Severity: Minor
            Found in DependencyInjection/Compiler/EntityCompilerPass.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            The class MagicAlterController has a coupling between objects value of 19. Consider to reduce the number of dependencies under 13.
            Open

            class MagicAlterController extends SymfonyController
{
    use CommonResponseTrait;

    const ERROR_ACCESS_DENIED = "Access to the resource was denied.",
            Severity: Minor
            Found in Controller/MagicAlterController.php by phpmd

            CouplingBetweenObjects

            Since: 1.1.0

            A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

            Example

            class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

            Source https://phpmd.org/rules/design.html#couplingbetweenobjects

            Method buildHttpClient has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    $url = NULL,
        $username = NULL,
        $password = NULL,
        $contentType = self::CONTENT_JSON_API,
        $language = self::HEADER_LOCALE
            Severity: Minor
            Found in Test/PHPUnit/ApiTestCase.php - About 35 mins to fix

              Method buildHttpClient has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      $url = NULL,
        $username = NULL,
        $password = NULL,
        $contentType = self::CONTENT_JSON_API,
        $language = self::HEADER_LOCALE
              Severity: Minor
              Found in Util/HttpClientUtil.php - About 35 mins to fix

                Multi-line function declarations must define one parameter per line
                Open

                        $expectedSchema, $actualJson, $message = ''
                Severity: Minor
                Found in Test/PHPUnit/ApiTestCase.php by phpcodesniffer
                Severity
                Category
                Status
                Source
                Language