skqr/hateoas

View on GitHub
Config/ResourceEntityMapper.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\GoIntegro\Hateoas\Util\Inflector' in method 'indexEntityClassNames'.
Open

            $resourceType = Util\Inflector::typify($name);
Severity: Minor
Found in Config/ResourceEntityMapper.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid variables with short names like $em. Configured minimum length is 3.
Open

    private $em;
Severity: Minor
Found in Config/ResourceEntityMapper.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $em. Configured minimum length is 3.
Open

        EntityManagerInterface $em,
Severity: Minor
Found in Config/ResourceEntityMapper.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {

Line exceeds 120 characters; contains 141 characters
Open

     * @todo The configuration doesn't actually allow overridding resource type to entity class mappings as the error message suggests. Oops.

Line exceeds 120 characters; contains 285 characters
Open

        ERROR_ENTITIES_PER_RESOURCE = "The resource \"%s\" listed in the RAML doc matches the following entity class names: \"%s\". If you want to keep the short-names of these resource entities you need to map all but one of them to other resource types in the bundle configuration.";

There are no issues that match your filters.

Category
Status