Sign upLogin

skqr/hateoas

View on GitHub
Star
Entity/DefaultBuilder.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\GoIntegro\Hateoas\Util\Reflection' in method 'create'.
Open

        $entity = Reflection::instance($class, $params);
Severity: Minor
Found in Entity/DefaultBuilder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid variables with short names like $em. Configured minimum length is 3.
Open

        EntityManagerInterface $em,
Severity: Minor
Found in Entity/DefaultBuilder.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $em. Configured minimum length is 3.
Open

    private $em;
Severity: Minor
Found in Entity/DefaultBuilder.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There must be one USE keyword per declaration
Open

use Doctrine\ORM\EntityManagerInterface,
Severity: Minor
Found in Entity/DefaultBuilder.php by phpcodesniffer

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {
Severity: Minor
Found in Entity/DefaultBuilder.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use Symfony\Component\Validator\ValidatorInterface,
Severity: Minor
Found in Entity/DefaultBuilder.php by phpcodesniffer

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {
Severity: Minor
Found in Entity/DefaultBuilder.php by phpcodesniffer

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {
Severity: Minor
Found in Entity/DefaultBuilder.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

            $class->getConstructor(), $fields, $relationships, $metadata
Severity: Minor
Found in Entity/DefaultBuilder.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

            $class->getConstructor(), $fields, $relationships, $metadata
Severity: Minor
Found in Entity/DefaultBuilder.php by phpcodesniffer

Only one argument is allowed per line in a multi-line function call
Open

            $class->getConstructor(), $fields, $relationships, $metadata
Severity: Minor
Found in Entity/DefaultBuilder.php by phpcodesniffer

Inline control structures are not allowed
Open

            foreach ($paramBags as &$bag) unset($bag[$name]);
Severity: Minor
Found in Entity/DefaultBuilder.php by phpcodesniffer

There are no issues that match your filters.

Category
Status