Sign upLogin

skqr/hateoas

View on GitHub
Star
Entity/DefaultMutator.php

Summary

Maintainability
A
55 mins
Test Coverage

Function updateTranslations has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private function updateTranslations(
        ResourceEntityInterface $entity, array $translations
    )
    {
        $repository = $this->em->getRepository(self::TRANSLATION_ENTITY);
Severity: Minor
Found in Entity/DefaultMutator.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid variables with short names like $em. Configured minimum length is 3.
Open

        EntityManagerInterface $em,
Severity: Minor
Found in Entity/DefaultMutator.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $em. Configured minimum length is 3.
Open

    private $em;
Severity: Minor
Found in Entity/DefaultMutator.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Multi-line function declarations must define one parameter per line
Open

        ResourceEntityInterface $entity, array $translations
Severity: Minor
Found in Entity/DefaultMutator.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use Doctrine\ORM\EntityManagerInterface,
Severity: Minor
Found in Entity/DefaultMutator.php by phpcodesniffer

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {
Severity: Minor
Found in Entity/DefaultMutator.php by phpcodesniffer

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
Open

                    throw new TranslationException($message, NULL, $e);
Severity: Minor
Found in Entity/DefaultMutator.php by phpcodesniffer

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
Open

                    throw new TranslationException($message, NULL, $e);
Severity: Minor
Found in Entity/DefaultMutator.php by phpcodesniffer

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {
Severity: Minor
Found in Entity/DefaultMutator.php by phpcodesniffer

The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
Open

    {
Severity: Minor
Found in Entity/DefaultMutator.php by phpcodesniffer

There are no issues that match your filters.

Category
Status