Sign upLogin

skqr/hateoas

View on GitHub
Star
Entity/Validating.php

Summary

Maintainability
A
0 mins
Test Coverage

The method validate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $errors = $this->validator->validate($entity);

            if (0 < count($errors)) {
                throw new Validation\ValidationException($errors);
Severity: Minor
Found in Entity/Validating.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Expected 0 spaces after opening bracket; newline found
Open

            if (
Severity: Minor
Found in Entity/Validating.php by phpcodesniffer

There are no issues that match your filters.

Category
Status