Sign upLogin

skqr/hateoas

View on GitHub
Star
JsonApi/Request/LinkBodyParser.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method parse has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function parse(Request $request, Params $params, array $body)
    {
        $entity = $params->entities->primary->first();
        $ids = NULL;
Severity: Minor
Found in JsonApi/Request/LinkBodyParser.php - About 1 hr to fix

    Function parseCreateAction has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function parseCreateAction($ids, array $relation)
    {
        if (is_array($ids)) {
            if (!is_array($relation)) {
                throw new ParseException(
    Severity: Minor
    Found in JsonApi/Request/LinkBodyParser.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function parse(Request $request, Params $params, array $body)
    {
        $entity = $params->entities->primary->first();
        $ids = NULL;
    Severity: Minor
    Found in JsonApi/Request/LinkBodyParser.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using static access to class '\GoIntegro\Hateoas\Util\Inflector' in method 'parse'.
    Open

            $method = 'get' . Util\Inflector::camelize($params->relationship);
    Severity: Minor
    Found in JsonApi/Request/LinkBodyParser.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused parameters such as '$request'.
    Open

        public function parse(Request $request, Params $params, array $body)
    Severity: Minor
    Found in JsonApi/Request/LinkBodyParser.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
    Open

            $ids = NULL;
    Severity: Minor
    Found in JsonApi/Request/LinkBodyParser.php by phpcodesniffer

    Expected 1 space after FUNCTION keyword; 0 found
    Open

                $callback = function($entity) {
    Severity: Minor
    Found in JsonApi/Request/LinkBodyParser.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status