Sign upLogin

skqr/hateoas

View on GitHub
Star
JsonApi/Request/PaginationParser.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\GoIntegro\Hateoas\Http\Url' in method 'parsePaginationlessUrl'.
Open

        return Url::fromString($url);
Severity: Minor
Found in JsonApi/Request/PaginationParser.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused local variables such as '$value'.
Open

                list($key, $value) = explode('=', $pair);
Severity: Minor
Found in JsonApi/Request/PaginationParser.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

There must be one USE keyword per declaration
Open

use Symfony\Component\HttpFoundation\Request,
Severity: Minor
Found in JsonApi/Request/PaginationParser.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

            $callback = function($pair) {
Severity: Minor
Found in JsonApi/Request/PaginationParser.php by phpcodesniffer

Inline control structures are not allowed
Open

        if (empty($params->primaryClass)) return $pagination;
Severity: Minor
Found in JsonApi/Request/PaginationParser.php by phpcodesniffer

There are no issues that match your filters.

Category
Status