JsonApi/Request/ResourceLinksHydrant.php
Function hydrate
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
Open
public function hydrate(Params $params, array &$resourceObject)
{
if (empty($resourceObject[self::LINKS])) {
return;
} elseif (!is_array($resourceObject[self::LINKS])) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method hydrate
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function hydrate(Params $params, array &$resourceObject)
{
if (empty($resourceObject[self::LINKS])) {
return;
} elseif (!is_array($resourceObject[self::LINKS])) {
Avoid variables with short names like $em. Configured minimum length is 3. Open
Open
EntityManagerInterface $em,
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $mm. Configured minimum length is 3. Open
Open
private $mm;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $mm. Configured minimum length is 3. Open
Open
MetadataMinerInterface $mm
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
Avoid variables with short names like $em. Configured minimum length is 3. Open
Open
private $em;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Open
Open
{
- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
Open
self::ERROR_LINKS_CONTENT_TYPE, $relationship
- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
Open
self::ERROR_LINKS_CONTENT, $relationship
- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
Open
self::ERROR_LINKS_CONTENT, $relationship
- Exclude checks