skqr/hateoas

View on GitHub
JsonApi/Request/ResourceLinksHydrant.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function hydrate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function hydrate(Params $params, array &$resourceObject)
    {
        if (empty($resourceObject[self::LINKS])) {
            return;
        } elseif (!is_array($resourceObject[self::LINKS])) {
Severity: Minor
Found in JsonApi/Request/ResourceLinksHydrant.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hydrate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function hydrate(Params $params, array &$resourceObject)
    {
        if (empty($resourceObject[self::LINKS])) {
            return;
        } elseif (!is_array($resourceObject[self::LINKS])) {
Severity: Minor
Found in JsonApi/Request/ResourceLinksHydrant.php - About 1 hr to fix

    Avoid variables with short names like $mm. Configured minimum length is 3.
    Open

        private $mm;

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $em. Configured minimum length is 3.
    Open

        private $em;

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $mm. Configured minimum length is 3.
    Open

            MetadataMinerInterface $mm

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $em. Configured minimum length is 3.
    Open

            EntityManagerInterface $em,

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
        private $q = 15; // VIOLATION - Field
        public static function main( array $as ) { // VIOLATION - Formal
            $r = 20 + $this->q; // VIOLATION - Local
            for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                $r += $this->q;
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#shortvariable

    The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
    Open

        {

    Only one argument is allowed per line in a multi-line function call
    Open

                            self::ERROR_LINKS_CONTENT, $relationship

    Only one argument is allowed per line in a multi-line function call
    Open

                        self::ERROR_LINKS_CONTENT_TYPE, $relationship

    Only one argument is allowed per line in a multi-line function call
    Open

                            self::ERROR_LINKS_CONTENT, $relationship

    There are no issues that match your filters.

    Category
    Status