JsonApi/Request/UnlinkBodyParser.php
Method parseDeleteAction
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
protected function parseDeleteAction(Params $params, $relation)
{
$ids = NULL;
if (!empty($params->relationshipIds)) {
Function parseDeleteAction
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function parseDeleteAction(Params $params, $relation)
{
$ids = NULL;
if (!empty($params->relationshipIds)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid using static access to class '\GoIntegro\Hateoas\Util\Inflector' in method 'parse'. Open
Open
$method = 'get' . Util\Inflector::camelize($params->relationship);
- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$request'. Open
Open
public function parse(Request $request, Params $params)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
Open
$ids = NULL;
- Exclude checks
Expected 1 space after FUNCTION keyword; 0 found Open
Open
$callback = function($entity) {
- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL" Open
Open
$ids = NULL;
- Exclude checks