skqr/hateoas

View on GitHub
JsonApi/TypedResourceCollection.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function getResource($type, $id)
Severity: Minor
Found in JsonApi/TypedResourceCollection.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function hasResource($type, $id)
Severity: Minor
Found in JsonApi/TypedResourceCollection.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
Open

            : NULL;

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
Open

            : NULL;

There must be one USE keyword per declaration
Open

use IteratorAggregate, ArrayIterator, Countable;

Expected 1 space after FUNCTION keyword; 0 found
Open

        $callback = function(array $itemList) use (&$flatList) {

There are no issues that match your filters.

Category
Status