Method getRelationships has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function getRelationships($entityClassName, $primaryType)
{
$relationships = new ResourceRelationships;
$metadata = $this->metadataCache->getMapping($entityClassName);
$class = $this->metadataCache->getReflection($entityClassName);Function getRelationships has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
protected function getRelationships($entityClassName, $primaryType)
{
$relationships = new ResourceRelationships;
$metadata = $this->metadataCache->getMapping($entityClassName);
$class = $this->metadataCache->getReflection($entityClassName);- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '201', column '27'). Open
throw new \Exception(self::ERROR_MAPPING_TYPE_UNKNOWN);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid using static access to class '\GoIntegro\Hateoas\Util\Reflection' in method 'isLinkOnlyRelation'. Open
|| !Reflection::isMethodGetter($class->getMethod($getterName));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\GoIntegro\Hateoas\Util\Inflector' in method 'getRelationships'. Open
$relationshipName = Inflector::hyphenate($name);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\GoIntegro\Hateoas\Util\Inflector' in method 'isLinkOnlyRelation'. Open
$getterName = 'get' . Inflector::camelize($name);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$primaryType'. Open
protected function getRelationships($entityClassName, $primaryType)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Open
{- Exclude checks
The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Open
{- Exclude checks
The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line Open
{- Exclude checks
Multi-line function declarations must define one parameter per line Open
MetadataCache $metadataCache, $resourceClassPath- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
$type, $subtype, $resourceClass, $fields, $relationships, $pageSize- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
$type, $subtype, $resourceClass, $fields, $relationships, $pageSize- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
$type, $subtype, $resourceClass, $fields, $relationships, $pageSize- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
$type, $subtype, $resourceClass, $fields, $relationships, $pageSize- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
$type, $subtype, $resourceClass, $fields, $relationships, $pageSize- Exclude checks