Sign upLogin

skqr/hateoas

View on GitHub
Star
Metadata/Resource/ResourceMetadata.php

Summary

Maintainability
A
45 mins
Test Coverage

Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $type,
        $subtype,
        \ReflectionClass $resourceClass,
        ResourceFields $fields,
        ResourceRelationships $relationships,
Severity: Minor
Found in Metadata/Resource/ResourceMetadata.php - About 45 mins to fix

    Missing class import via use statement (line '143', column '36').
    Open

            $this->resourceClass = new \ReflectionClass($import['resourceClass']);
    Severity: Minor
    Found in Metadata/Resource/ResourceMetadata.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\GoIntegro\Hateoas\Util\Reflection' in method 'getInjectedFields'.
    Open

                if (Reflection::isMethodInjector($method)) {
    Severity: Minor
    Found in Metadata/Resource/ResourceMetadata.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\GoIntegro\Hateoas\Util\Inflector' in method 'fieldFromInjector'.
    Open

            return Inflector::hyphenate($name);
    Severity: Minor
    Found in Metadata/Resource/ResourceMetadata.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused parameters such as '$pageSize'.
    Open

            $pageSize = NULL
    Severity: Minor
    Found in Metadata/Resource/ResourceMetadata.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
    Open

        {
    Severity: Minor
    Found in Metadata/Resource/ResourceMetadata.php by phpcodesniffer

    TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
    Open

            $pageSize = NULL
    Severity: Minor
    Found in Metadata/Resource/ResourceMetadata.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status