The method camelize has a boolean flag argument $firstToUpper, which is a certain sign of a Single Responsibility Principle violation. Open
public static function camelize($word, $firstToUpper = FALSE)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class '\Doctrine\Common\Util\Inflector' in method 'pluralize'. Open
return DoctrineInflector::pluralize($word);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method shortenClassName uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
++$position;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
public static function camelize($word, $firstToUpper = FALSE)- Exclude checks
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if (FALSE === $position) {- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
' ', '', ucwords(str_replace('-', ' ', $word))- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
' ', '', ucwords(str_replace('-', ' ', $word))- Exclude checks