Sign upLogin

skqr/raml

View on GitHub
Star
Root/ResourceType.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function copy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private function copy(array $source, array $values)
    {
        foreach ($source as $key => &$value) {
            $params = $this->parseParams($key);
Severity: Minor
Found in Root/ResourceType.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function apply has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function apply($type, array $node)
    {
        $copy = NULL;

        if (empty($node['type'])) {
Severity: Minor
Found in Root/ResourceType.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '67', column '23').
Open

            throw new \ErrorException($message);
Severity: Minor
Found in Root/ResourceType.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '49', column '23').
Open

            throw new \ErrorException($message);
Severity: Minor
Found in Root/ResourceType.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '62', column '23').
Open

            throw new \ErrorException($message);
Severity: Minor
Found in Root/ResourceType.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method apply uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $message = "The resource type declaration is neither a string nor a map.";
            throw new \ErrorException($message);
        }
Severity: Minor
Found in Root/ResourceType.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    private function copy(array $source, array $values)
    {
        foreach ($source as $key => &$value) {
            $params = $this->parseParams($key);
Severity: Major
Found in Root/ResourceType.php and 1 other location - About 4 hrs to fix
Root/RamlTrait.php on lines 83..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 177.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
Open

        $this->usage = !empty($source['usage']) ? $source['usage'] : NULL;
Severity: Minor
Found in Root/ResourceType.php by phpcodesniffer

Each PHP statement must be on a line by itself
Open

        $callback = function($param) { return '<<' . $param . '>>'; };
Severity: Minor
Found in Root/ResourceType.php by phpcodesniffer

TRUE, FALSE and NULL must be lowercase; expected "null" but found "NULL"
Open

        $copy = NULL;
Severity: Minor
Found in Root/ResourceType.php by phpcodesniffer

Expected 1 space after FUNCTION keyword; 0 found
Open

        $callback = function($param) { return '<<' . $param . '>>'; };
Severity: Minor
Found in Root/ResourceType.php by phpcodesniffer

Opening brace must be the last content on the line
Open

        $callback = function($param) { return '<<' . $param . '>>'; };
Severity: Minor
Found in Root/ResourceType.php by phpcodesniffer

Closing brace must be on a line by itself
Open

        $callback = function($param) { return '<<' . $param . '>>'; };
Severity: Minor
Found in Root/ResourceType.php by phpcodesniffer

Expected 0 spaces after opening bracket; newline found
Open

        } elseif (
Severity: Minor
Found in Root/ResourceType.php by phpcodesniffer

There are no issues that match your filters.

Category
Status