skroutz/skroutz.rb

View on GitHub

Showing 2 of 2 total issues

Method define_association has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def define_association(name, options) # rubocop:disable Metrics/AbcSize
      define_method(name) do
        class_name = options.fetch(:class_name, name.to_s).classify.pluralize
        owner = attributes.key?("#{name}_id") ? nil : self
        prefix = options[:class_name] && owner ? name.to_s : nil
Severity: Minor
Found in lib/skroutz/associations.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method attribute_for_inspect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def attribute_for_inspect(value) # rubocop: disable all
    if value.is_a?(String) && value.length > 50
      "#{value[0, 50]}...".inspect
    elsif value.is_a?(Date) || value.is_a?(Time)
      %("#{value.to_s(:db)}")
Severity: Minor
Found in lib/skroutz/resource.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language