Sign upLogin

skyverge/wc-plugin-framework

View on GitHub
Star
woocommerce/compatibility/class-sv-wc-order-compatibility.php

Summary

Maintainability
C
1 day
Test Coverage

Consider simplifying this complex logical expression.
Open

if ( ! class_exists( '\\SkyVerge\\WooCommerce\\PluginFramework\\v5_12_4\\SV_WC_Order_Compatibility' ) ) :


/**
 * WooCommerce order compatibility class.
Severity: Critical
Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php - About 2 hrs to fix

    Function delete_order_meta has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function delete_order_meta( $order, string $meta_key, $meta_value = '' ) {

        if ( SV_WC_Plugin_Compatibility::is_hpos_enabled() ) {

            $order = is_numeric( $order ) && $order > 0 ? wc_get_order( (int) $order ) : $order;
    Severity: Minor
    Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function update_order_meta has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function update_order_meta( $order, string $meta_key, $meta_value ) {

        if ( SV_WC_Plugin_Compatibility::is_hpos_enabled() ) {

            $order = is_numeric( $order ) && $order > 0 ? wc_get_order( (int) $order ) : $order;
    Severity: Minor
    Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_order_meta has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function add_order_meta( $order, string $meta_key, $meta_value, bool $unique = false ) {

        if ( SV_WC_Plugin_Compatibility::is_hpos_enabled() ) {

            $order = is_numeric( $order ) && $order > 0 ? wc_get_order( (int) $order ) : $order;
    Severity: Minor
    Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function order_meta_exists has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function order_meta_exists( $order, string $meta_key ) : bool {

        if ( SV_WC_Plugin_Compatibility::is_hpos_enabled() ) {

            $order = is_numeric( $order ) && $order > 0 ? wc_get_order( (int) $order ) : $order;
    Severity: Minor
    Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function is_orders_screen_for_status has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function is_orders_screen_for_status( $status ) : bool {
        global $post_type, $post_status;

        if ( ! SV_WC_Plugin_Compatibility::is_hpos_enabled() ) {
    Severity: Minor
    Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function is_order has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function is_order( $post_order_or_id, $order_type = 'shop_order' ) : bool {

        if ( ! $post_order_or_id ) {
            return false;
        }
    Severity: Minor
    Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_order_meta has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function get_order_meta( $order, string $meta_key, bool $single = true ) {

        if ( SV_WC_Plugin_Compatibility::is_hpos_enabled() ) {

            $value = $single ? '' : [];
    Severity: Minor
    Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_item_formatted_meta_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function get_item_formatted_meta_data( $item, $hide_prefix = '_', $include_all = false ) {

        if ( $item instanceof \WC_Order_Item && SV_WC_Plugin_Compatibility::is_wc_version_gte( '3.1' ) ) {

            $meta_data = $item->get_formatted_meta_data( $hide_prefix, $include_all );
    Severity: Minor
    Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public static function is_order_edit_screen() : bool {

        $current_screen = SV_WC_Helper::get_current_screen();

        if ( ! $current_screen ) {
    Severity: Major
    Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php and 1 other location - About 1 hr to fix
    woocommerce/compatibility/class-sv-wc-subscription-compatibility.php on lines 63..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public static function is_orders_screen() : bool {

        $current_screen = SV_WC_Helper::get_current_screen();

        if ( ! $current_screen ) {
    Severity: Minor
    Found in woocommerce/compatibility/class-sv-wc-order-compatibility.php and 1 other location - About 40 mins to fix
    woocommerce/compatibility/class-sv-wc-subscription-compatibility.php on lines 88..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status