Sign upLogin

skywarth/Fenrir-wolfpack-simulator

View on GitHub
Star

Showing 26 of 72 total issues

Function calculateAlphaPoints has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

function calculateAlphaPoints(){
    for(let i=1;i<wolves.length;i++)
    {
        //age, diseases, anatomic sizes, marks, characteristics,
        let alphaP=100;
Severity: Minor
Found in modules/modifiers.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

for(var i = 0; i < biomeTemplates.length; i++) {
    var opt = biomeTemplates[i].name;
    var el = document.createElement("option");
    el.textContent = opt;
    el.value = biomeTemplates[i].id;
Severity: Major
Found in modules/wolfModule.js and 1 other location - About 3 hrs to fix
modules/wolfModule.js on lines 18..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    for(var i = 0; i < diseaseTemplates.length; i++) {
        var opt = diseaseTemplates[i].name;
        var el = document.createElement("option");
        el.textContent = opt;
        el.value = diseaseTemplates[i].id;
Severity: Major
Found in modules/wolfModule.js and 1 other location - About 3 hrs to fix
modules/wolfModule.js on lines 39..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function calculateAlphaPoints has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function calculateAlphaPoints(){
    for(let i=1;i<wolves.length;i++)
    {
        //age, diseases, anatomic sizes, marks, characteristics,
        let alphaP=100;
Severity: Major
Found in modules/modifiers.js - About 2 hrs to fix

    Function hunt has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        static hunt(){
        if(currentPreyScoutStatus)
        {simulationLogs.push(new simulationLog(currentDate,"Hunt", "Wolf pack is on the prowl according to their scout activity findings."));
            if(currentPreyCount>=1){
                simulationLogs.push(new simulationLog(currentDate,"Hunt", "Wolf pack has found the prey/prey group. Engaging now."));
    Severity: Minor
    Found in modules/eventModule.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function calculateBiomeBasedHuntSuccesChance has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

    function calculateBiomeBasedHuntSuccesChance(){


    for(let i=1;i<wolves.length;i++)
    {
    Severity: Minor
    Found in modules/modifiers.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            else if((wolves[i].definitiveFields.familySet.name==="forest" || wolves[i].definitiveFields.familySet.name==="jungle")  && (environment.biome.name==="forest" || environment.biome.name==="jungle"))
        {
            biomeBasedHuntSuccessChance+=(30/wolves.length);
        }
    Severity: Major
    Found in modules/modifiers.js and 3 other locations - About 2 hrs to fix
    modules/modifiers.js on lines 11..31
    modules/modifiers.js on lines 21..31
    modules/modifiers.js on lines 25..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            else if((wolves[i].definitiveFields.familySet.name==="tundra" || wolves[i].definitiveFields.familySet.name==="plains")  && (environment.biome.name==="tundra" || environment.biome.name==="plains"))
        {
            biomeBasedHuntSuccessChance+=(30/wolves.length);
        }
        else if((wolves[i].definitiveFields.familySet.name==="tundra" || wolves[i].definitiveFields.familySet.name==="plains")  && (environment.biome.name==="tundra" || environment.biome.name==="plains"))
    Severity: Major
    Found in modules/modifiers.js and 3 other locations - About 2 hrs to fix
    modules/modifiers.js on lines 11..31
    modules/modifiers.js on lines 16..31
    modules/modifiers.js on lines 25..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            else if((wolves[i].definitiveFields.familySet.name==="tundra" || wolves[i].definitiveFields.familySet.name==="plains")  && (environment.biome.name==="tundra" || environment.biome.name==="plains"))
        {
            biomeBasedHuntSuccessChance+=(30/wolves.length);
        }
        else{
    Severity: Major
    Found in modules/modifiers.js and 3 other locations - About 2 hrs to fix
    modules/modifiers.js on lines 11..31
    modules/modifiers.js on lines 16..31
    modules/modifiers.js on lines 21..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            else if((wolves[i].definitiveFields.familySet.name==="arctic" || wolves[i].definitiveFields.familySet.name==="taiga")  && (environment.biome.name==="arctic" || environment.biome.name==="taiga"))
        {
            biomeBasedHuntSuccessChance+=(30/wolves.length);
        }
    Severity: Major
    Found in modules/modifiers.js and 3 other locations - About 2 hrs to fix
    modules/modifiers.js on lines 16..31
    modules/modifiers.js on lines 21..31
    modules/modifiers.js on lines 25..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function regularTrigger has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    function regularTrigger(){
    simulationLogs.push(new simulationLog(new simulationLog(currentDate,"Simulation","Simulation has started")));
    let bookmarkStart=0;

    for(let i=1;i<10;i++){
    Severity: Minor
    Found in modules/simulationModule.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if(wolves[i].definitiveFields.wolfAnatomicSizes.skullDiameter>wolves[l].definitiveFields.wolfAnatomicSizes.skullDiameter){
                alphaP+=2;
            }
            else if(wolves[i].definitiveFields.wolfAnatomicSizes.skullDiameter===wolves[l].definitiveFields.wolfAnatomicSizes.skullDiameter){
                //same wolf
    Severity: Major
    Found in modules/modifiers.js and 1 other location - About 1 hr to fix
    modules/modifiers.js on lines 173..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if(wolves[i].definitiveFields.wolfAnatomicSizes.foreLegHeight>wolves[l].definitiveFields.wolfAnatomicSizes.foreLegHeight){
                alphaP+=2;
            }
            else if(wolves[i].definitiveFields.wolfAnatomicSizes.foreLegHeight===wolves[l].definitiveFields.wolfAnatomicSizes.foreLegHeight){
                //same wolf
    Severity: Major
    Found in modules/modifiers.js and 1 other location - About 1 hr to fix
    modules/modifiers.js on lines 155..163

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function hunt has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static hunt(){
        if(currentPreyScoutStatus)
        {simulationLogs.push(new simulationLog(currentDate,"Hunt", "Wolf pack is on the prowl according to their scout activity findings."));
            if(currentPreyCount>=1){
                simulationLogs.push(new simulationLog(currentDate,"Hunt", "Wolf pack has found the prey/prey group. Engaging now."));
    Severity: Minor
    Found in modules/eventModule.js - About 1 hr to fix

      Function calculateBiomeBasedHuntSuccesChance has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function calculateBiomeBasedHuntSuccesChance(){


    for(let i=1;i<wolves.length;i++)
    {
      Severity: Minor
      Found in modules/modifiers.js - About 1 hr to fix

        Function regularTrigger has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function regularTrigger(){
    simulationLogs.push(new simulationLog(new simulationLog(currentDate,"Simulation","Simulation has started")));
    let bookmarkStart=0;

    for(let i=1;i<10;i++){
        Severity: Minor
        Found in modules/simulationModule.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  let diseaseTemplateObj = diseaseTemplates.find(function(element) {
            let id=$("#disease"+i).val();
            return element.id ==id;
        });
          Severity: Minor
          Found in modules/wolfModule.js and 1 other location - About 55 mins to fix
          modules/wolfModule.js on lines 94..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  let diseaseTemplateObj = diseaseTemplates.find(function(element) {
            let id=$("#disease"+i).val();
            return element.id ==id;
        });
          Severity: Minor
          Found in modules/wolfModule.js and 1 other location - About 55 mins to fix
          modules/wolfModule.js on lines 60..63

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid deeply nested control flow statements.
          Open

                                  if(environment.preyType===keys[i]){
                            return values[i];
                        }
          Severity: Major
          Found in modules/eventModule.js - About 45 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        if(wolves[i].definitiveFields.strMark>wolves[l].definitiveFields.strMark){
                alphaP+=5;
            }
            else if(wolves[i].definitiveFields.strMark===wolves[l].definitiveFields.strMark){
                //same wolf
            Severity: Major
            Found in modules/modifiers.js and 2 other locations - About 40 mins to fix
            modules/modifiers.js on lines 143..151
            modules/modifiers.js on lines 204..212

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language