slack-ruby/slack-ruby-client

View on GitHub
lib/slack/web/api/endpoints/chat.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          def chat_command(options = {})
            raise ArgumentError, 'Required arguments :channel missing' if options[:channel].nil?
            raise ArgumentError, 'Required arguments :command missing' if options[:command].nil?
            options = options.merge(channel: conversations_id(options)['channel']['id']) if options[:channel]
            logger.warn('The chat.command method is undocumented.')
Severity: Minor
Found in lib/slack/web/api/endpoints/chat.rb and 1 other location - About 45 mins to fix
lib/slack/web/api/endpoints/files.rb on lines 142..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

          def chat_delete(options = {})
            raise ArgumentError, 'Required arguments :channel missing' if options[:channel].nil?
            raise ArgumentError, 'Required arguments :ts missing' if options[:ts].nil?
            options = options.merge(channel: conversations_id(options)['channel']['id']) if options[:channel]
            post('chat.delete', options)
Severity: Major
Found in lib/slack/web/api/endpoints/chat.rb and 8 other locations - About 40 mins to fix
lib/slack/web/api/endpoints/chat.rb on lines 56..60
lib/slack/web/api/endpoints/chat.rb on lines 72..76
lib/slack/web/api/endpoints/conversations.rb on lines 160..164
lib/slack/web/api/endpoints/conversations.rb on lines 282..286
lib/slack/web/api/endpoints/conversations.rb on lines 339..343
lib/slack/web/api/endpoints/conversations.rb on lines 389..393
lib/slack/web/api/endpoints/conversations.rb on lines 405..409
lib/slack/web/api/endpoints/reminders.rb on lines 24..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

          def chat_getPermalink(options = {})
            raise ArgumentError, 'Required arguments :channel missing' if options[:channel].nil?
            raise ArgumentError, 'Required arguments :message_ts missing' if options[:message_ts].nil?
            options = options.merge(channel: conversations_id(options)['channel']['id']) if options[:channel]
            post('chat.getPermalink', options)
Severity: Major
Found in lib/slack/web/api/endpoints/chat.rb and 8 other locations - About 40 mins to fix
lib/slack/web/api/endpoints/chat.rb on lines 38..42
lib/slack/web/api/endpoints/chat.rb on lines 56..60
lib/slack/web/api/endpoints/conversations.rb on lines 160..164
lib/slack/web/api/endpoints/conversations.rb on lines 282..286
lib/slack/web/api/endpoints/conversations.rb on lines 339..343
lib/slack/web/api/endpoints/conversations.rb on lines 389..393
lib/slack/web/api/endpoints/conversations.rb on lines 405..409
lib/slack/web/api/endpoints/reminders.rb on lines 24..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

          def chat_deleteScheduledMessage(options = {})
            raise ArgumentError, 'Required arguments :channel missing' if options[:channel].nil?
            raise ArgumentError, 'Required arguments :scheduled_message_id missing' if options[:scheduled_message_id].nil?
            options = options.merge(channel: conversations_id(options)['channel']['id']) if options[:channel]
            post('chat.deleteScheduledMessage', options)
Severity: Major
Found in lib/slack/web/api/endpoints/chat.rb and 8 other locations - About 40 mins to fix
lib/slack/web/api/endpoints/chat.rb on lines 38..42
lib/slack/web/api/endpoints/chat.rb on lines 72..76
lib/slack/web/api/endpoints/conversations.rb on lines 160..164
lib/slack/web/api/endpoints/conversations.rb on lines 282..286
lib/slack/web/api/endpoints/conversations.rb on lines 339..343
lib/slack/web/api/endpoints/conversations.rb on lines 389..393
lib/slack/web/api/endpoints/conversations.rb on lines 405..409
lib/slack/web/api/endpoints/reminders.rb on lines 24..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status