Sign upLogin

slack-ruby/slack-ruby-client

View on GitHub
Star
lib/slack/web/api/endpoints/files_remote.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

          def files_remote_list(options = {})
            options = options.merge(channel: conversations_id(options)['channel']['id']) if options[:channel]
            if block_given?
              Pagination::Cursor.new(self, :files_remote_list, options).each do |page|
                yield page
Severity: Major
Found in lib/slack/web/api/endpoints/files_remote.rb and 4 other locations - About 35 mins to fix
lib/slack/web/api/endpoints/chat_scheduledMessages.rb on lines 26..33
lib/slack/web/api/endpoints/reactions.rb on lines 63..70
lib/slack/web/api/endpoints/team.rb on lines 45..52
lib/slack/web/api/endpoints/users.rb on lines 26..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

          def files_remote_add(options = {})
            raise ArgumentError, 'Required arguments :external_id missing' if options[:external_id].nil?
            raise ArgumentError, 'Required arguments :external_url missing' if options[:external_url].nil?
            raise ArgumentError, 'Required arguments :title missing' if options[:title].nil?
            post('files.remote.add', options)
Severity: Major
Found in lib/slack/web/api/endpoints/files_remote.rb and 8 other locations - About 25 mins to fix
lib/slack/web/api/endpoints/admin_auth_policy.rb on lines 20..24
lib/slack/web/api/endpoints/admin_auth_policy.rb on lines 62..66
lib/slack/web/api/endpoints/admin_barriers.rb on lines 20..24
lib/slack/web/api/endpoints/admin_conversations_restrictAccess.rb on lines 51..55
lib/slack/web/api/endpoints/admin_roles.rb on lines 20..24
lib/slack/web/api/endpoints/admin_roles.rb on lines 63..67
lib/slack/web/api/endpoints/admin_users.rb on lines 55..59
lib/slack/web/api/endpoints/bookmarks.rb on lines 28..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status