Sign upLogin

sleekbyte/tailor

View on GitHub
Star
src/test/java/com/sleekbyte/tailor/functional/FormatTest.java

Summary

Maintainability
C
1 day
Test Coverage

File FormatTest.java has 340 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.sleekbyte.tailor.functional;

import static org.junit.Assert.assertArrayEquals;

import com.github.mustachejava.DefaultMustacheFactory;
Severity: Minor
Found in src/test/java/com/sleekbyte/tailor/functional/FormatTest.java - About 4 hrs to fix

    Method getCCMessages has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private List<Map<String, Object>> getCCMessages() {
        List<Map<String, Object>> violations = new ArrayList<>();

        for (ViolationMessage msg : getExpectedMsgs()) {
            Map<String, Object> violation = new HashMap<>();
    Severity: Minor
    Found in src/test/java/com/sleekbyte/tailor/functional/FormatTest.java - About 1 hr to fix

      Method getHTMLMessages has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private Map<String, Object> getHTMLMessages() throws IOException {
        List<Map<String, Object>> violations = new ArrayList<>();
        for (ViolationMessage msg : getExpectedMsgs()) {
            Map<String, Object> violation = new HashMap<>();
            Map<String, Object> location = new HashMap<>();
      Severity: Minor
      Found in src/test/java/com/sleekbyte/tailor/functional/FormatTest.java - About 1 hr to fix

        Method testHTMLFormat has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Test
    public void testHTMLFormat() throws IOException {
        Format format = Format.HTML;

        final String[] command = new String[] {
        Severity: Minor
        Found in src/test/java/com/sleekbyte/tailor/functional/FormatTest.java - About 1 hr to fix

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      if (msg.getColumnNumber() != 0) {
                begin.put(Messages.LINE_KEY, msg.getLineNumber());
                begin.put(Messages.COLUMN_KEY, msg.getColumnNumber());
                end.put(Messages.LINE_KEY, msg.getLineNumber());
                end.put(Messages.COLUMN_KEY, msg.getColumnNumber());
          Severity: Major
          Found in src/test/java/com/sleekbyte/tailor/functional/FormatTest.java and 2 other locations - About 2 hrs to fix
          src/main/java/com/sleekbyte/tailor/format/CCFormatter.java on lines 39..51
          src/test/java/com/sleekbyte/tailor/format/CCFormatterTest.java on lines 109..121

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 146.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  expectedMessages.addAll(getExpectedMsgs().stream().map(msg -> Printer.genOutputStringForTest(
            msg.getRule(),
            inputFile.getName(),
            msg.getLineNumber(),
            msg.getColumnNumber(),
          Severity: Minor
          Found in src/test/java/com/sleekbyte/tailor/functional/FormatTest.java and 1 other location - About 40 mins to fix
          src/test/java/com/sleekbyte/tailor/functional/FormatTest.java on lines 158..164

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  expectedMessages.addAll(getExpectedMsgs().stream().map(msg -> Printer.genOutputStringForTest(
            msg.getRule(),
            inputFile.getName(),
            msg.getLineNumber(),
            msg.getColumnNumber(),
          Severity: Minor
          Found in src/test/java/com/sleekbyte/tailor/functional/FormatTest.java and 1 other location - About 40 mins to fix
          src/test/java/com/sleekbyte/tailor/functional/FormatTest.java on lines 87..93

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      switch (msg.getSeverity()) {
                case ERROR:
                    violation.put(Messages.ERROR, true);
                    break;
                case WARNING:
          Severity: Minor
          Found in src/test/java/com/sleekbyte/tailor/functional/FormatTest.java and 2 other locations - About 35 mins to fix
          src/main/java/com/sleekbyte/tailor/format/HTMLFormatter.java on lines 53..62
          src/test/java/com/sleekbyte/tailor/format/HTMLFormatterTest.java on lines 122..131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status