Sign upLogin

sleekbyte/tailor

View on GitHub
Star
src/test/java/com/sleekbyte/tailor/functional/MaxNameLengthTest.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method addAllExpectedMsgs has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    protected void addAllExpectedMsgs() {
        addExpectedNameMsg(1, 7, Messages.CLASS + Messages.NAME, 23, 5);
        addExpectedNameMsg(4, 5, Messages.CONSTANT + Messages.NAME, 22, 5);
        addExpectedLineMsg(4, 41, Messages.LINE, 75, 40);
Severity: Minor
Found in src/test/java/com/sleekbyte/tailor/functional/MaxNameLengthTest.java - About 1 hr to fix

    Method addExpectedLineMsg has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private void addExpectedLineMsg(int line, int column, String msg, int length, int limit) {
    Severity: Minor
    Found in src/test/java/com/sleekbyte/tailor/functional/MaxNameLengthTest.java - About 35 mins to fix

      Method addExpectedNameMsg has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private void addExpectedNameMsg(int line, int column, String msg, int length, int limit) {
      Severity: Minor
      Found in src/test/java/com/sleekbyte/tailor/functional/MaxNameLengthTest.java - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private void addExpectedLineMsg(int line, int column, String msg, int length, int limit) {
        String lengthVersusLimit = " (" + length + "/" + limit + ")";
        msg += Messages.EXCEEDS_CHARACTER_LIMIT + lengthVersusLimit;
        expectedMessages.add(Printer.genOutputStringForTest(Rules.MAX_LINE_LENGTH, inputFile.getName(), line, column,
            Severity.WARNING, msg));
        Severity: Major
        Found in src/test/java/com/sleekbyte/tailor/functional/MaxNameLengthTest.java and 1 other location - About 1 hr to fix
        src/test/java/com/sleekbyte/tailor/functional/MaxNameLengthTest.java on lines 56..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private void addExpectedNameMsg(int line, int column, String msg, int length, int limit) {
        String lengthVersusLimit = " (" + length + "/" + limit + ")";
        msg += Messages.EXCEEDS_CHARACTER_LIMIT + lengthVersusLimit;
        expectedMessages.add(Printer.genOutputStringForTest(Rules.MAX_NAME_LENGTH, inputFile.getName(), line, column,
            Severity.WARNING, msg));
        Severity: Major
        Found in src/test/java/com/sleekbyte/tailor/functional/MaxNameLengthTest.java and 1 other location - About 1 hr to fix
        src/test/java/com/sleekbyte/tailor/functional/MaxNameLengthTest.java on lines 63..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status