sleekbyte/tailor

View on GitHub
src/test/java/com/sleekbyte/tailor/output/PrinterTest.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method validateViolationMessage has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private void validateViolationMessage(ViolationMessage message, Rules rule, String msg,
                                             int line, int column) {
Severity: Minor
Found in src/test/java/com/sleekbyte/tailor/output/PrinterTest.java - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
        public void testWarn() throws IOException {
            printer.warn(Rules.LOWER_CAMEL_CASE, WARNING_MSG, new Location(LINE_NUMBER, COLUMN_NUMBER));
            ViolationMessage message = printer.getViolationMessages().get(0);
            assertEquals(message.getSeverity(), Severity.WARNING);
    Severity: Minor
    Found in src/test/java/com/sleekbyte/tailor/output/PrinterTest.java and 1 other location - About 1 hr to fix
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 50..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @Test
        public void testError() throws IOException {
            printer.error(Rules.LOWER_CAMEL_CASE, ERROR_MSG, new Location(LINE_NUMBER, COLUMN_NUMBER));
            ViolationMessage message = printer.getViolationMessages().get(0);
            assertEquals(message.getSeverity(), Severity.ERROR);
    Severity: Minor
    Found in src/test/java/com/sleekbyte/tailor/output/PrinterTest.java and 1 other location - About 1 hr to fix
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 60..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        @Test
        public void testWarnWithMaxSeverityWarn() throws IOException {
            warnPrinter.warn(Rules.LOWER_CAMEL_CASE, WARNING_MSG, new Location(LINE_NUMBER, COLUMN_NUMBER));
            ViolationMessage message = warnPrinter.getViolationMessages().get(0);
            assertEquals(Severity.WARNING, message.getSeverity());
    Severity: Major
    Found in src/test/java/com/sleekbyte/tailor/output/PrinterTest.java and 3 other locations - About 45 mins to fix
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 70..76
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 78..84
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 86..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        @Test
        public void testWarnWithLocationSuccess() throws IOException {
            printer.warn(Rules.LOWER_CAMEL_CASE, WARNING_MSG, new Location(LINE_NUMBER, COLUMN_NUMBER));
            ViolationMessage message = printer.getViolationMessages().get(0);
            assertEquals(Severity.WARNING, message.getSeverity());
    Severity: Major
    Found in src/test/java/com/sleekbyte/tailor/output/PrinterTest.java and 3 other locations - About 45 mins to fix
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 78..84
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 86..92
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 94..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        @Test
        public void testErrorWithLocationSuccess() throws IOException {
            printer.error(Rules.LOWER_CAMEL_CASE, ERROR_MSG, new Location(LINE_NUMBER, COLUMN_NUMBER));
            ViolationMessage message = printer.getViolationMessages().get(0);
            assertEquals(Severity.ERROR, message.getSeverity());
    Severity: Major
    Found in src/test/java/com/sleekbyte/tailor/output/PrinterTest.java and 3 other locations - About 45 mins to fix
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 70..76
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 86..92
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 94..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        @Test
        public void testErrorWithMaxSeverityWarn() throws IOException {
            warnPrinter.error(Rules.LOWER_CAMEL_CASE, ERROR_MSG, new Location(LINE_NUMBER, COLUMN_NUMBER));
            ViolationMessage message = warnPrinter.getViolationMessages().get(0);
            assertEquals(Severity.WARNING, message.getSeverity());
    Severity: Major
    Found in src/test/java/com/sleekbyte/tailor/output/PrinterTest.java and 3 other locations - About 45 mins to fix
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 70..76
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 78..84
    src/test/java/com/sleekbyte/tailor/output/PrinterTest.java on lines 94..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status