Sign upLogin

sleepepi/sleepportal

View on GitHub
Star
app/models/report.rb

Summary

Maintainability
F
5 days
Test Coverage

Method finalize_report_table has a Cognitive Complexity of 153 (exceeds 5 allowed). Consider refactoring.
Open

  def finalize_report_table(current_user, include_html = true)

    result_hash = self.generate_report_table(current_user)

    values = result_hash[:values]
Severity: Minor
Found in app/models/report.rb - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_report_table has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

  def generate_report_table(current_user)
    filtered_report_concepts = self.report_concepts.select{|rc| not rc.position.blank?}
    values = self.search.view_concept_values(current_user, filtered_report_concepts)

    row_values = []
Severity: Minor
Found in app/models/report.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method finalize_report_table has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def finalize_report_table(current_user, include_html = true)

    result_hash = self.generate_report_table(current_user)

    values = result_hash[:values]
Severity: Major
Found in app/models/report.rb - About 3 hrs to fix

    Method generate_report_table has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def generate_report_table(current_user)
    filtered_report_concepts = self.report_concepts.select{|rc| not rc.position.blank?}
    values = self.search.view_concept_values(current_user, filtered_report_concepts)

    row_values = []
    Severity: Major
    Found in app/models/report.rb - About 2 hrs to fix

      Avoid deeply nested control flow statements.
      Open

              values.each{|v| v[index] = v[index].strftime("%Y-%m-%d") if v[index].kind_of?(Date) or v[index].kind_of?(Time)}
      Severity: Major
      Found in app/models/report.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                    elsif statistic == 'avg'
              body_row[index] = (filtered_results.compact.size > 0) ? (filtered_results.compact.sum.to_f / filtered_results.compact.size).round(1) : 'n/a'
            elsif statistic == 'count'
              body_row[index] = filtered_results.size
            elsif statistic == '%'
        Severity: Major
        Found in app/models/report.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                        body_row[index] = (filtered_results.compact.size > 0) ? (filtered_results.compact.max).round(1) : 'n/a'
          Severity: Major
          Found in app/models/report.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                            if report_concept.statistic == 'day'
                  filtered_results.select!{|d| (d.kind_of?(Date) or d.kind_of?(Time)) and d.strftime("%Y-%m-%d") == statistic.to_s.split(' ')[0..-2].join(' ')}
                elsif report_concept.statistic == 'week'
                  filtered_results.select!{|d| (d.kind_of?(Date) or d.kind_of?(Time)) and "#{d.year} Week #{'%02d' % d.to_date.cweek}" == statistic.to_s.split(' ')[0..-2].join(' ')}
                elsif report_concept.statistic == 'month' or report_concept.statistic.blank?
            Severity: Major
            Found in app/models/report.rb - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                            if orig_results_size > 0
                body_row[index] = (include_html ? color_for_number((filtered_results.size.to_f / orig_results_size * 100), "#{(filtered_results.size.to_f / orig_results_size * 100).round(1)}%") : "#{(filtered_results.size.to_f / orig_results_size * 100).round(1)}%")
              else
                body_row[index] = "---"
              Severity: Minor
              Found in app/models/report.rb and 1 other location - About 55 mins to fix
              app/models/report.rb on lines 208..211

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if strata_results_size > 0
                  body_row[index] = (include_html ? color_for_number((filtered_results.size.to_f / strata_results_size * 100), "#{(filtered_results.size.to_f / strata_results_size * 100).round(1)}%") : "#{(filtered_results.size.to_f / strata_results_size * 100).round(1)}%")
                else
                  body_row[index] = "---"
              Severity: Minor
              Found in app/models/report.rb and 1 other location - About 55 mins to fix
              app/models/report.rb on lines 199..202

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      row_values[index] = values.collect{|v| v[index]}.uniq.partition{|x| x.is_a? String}.map{|i| i.sort{|a,b| a.to_s <=> b.to_s}}.flatten
              Severity: Minor
              Found in app/models/report.rb and 1 other location - About 20 mins to fix
              app/models/report.rb on lines 61..61

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 27.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      values.collect{|v| v[index]}.uniq.partition{|x| x.is_a? String}.map{|i| i.sort{|a,b| a.to_s <=> b.to_s}}.flatten.each do |val|
              Severity: Minor
              Found in app/models/report.rb and 1 other location - About 20 mins to fix
              app/models/report.rb on lines 43..43

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 27.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status