Sign upLogin

sleepepi/sleepportal

View on GitHub
Star

Showing 436 of 436 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (off > chart.plotWidth) {
            if (align === 'left') {
                options.align = 'right';
            } else {
                options.x = chart.plotWidth - off;
Severity: Major
Found in app/assets/javascripts/external/highcharts-3.0.7.src.js and 1 other location - About 1 hr to fix
app/assets/javascripts/external/highcharts-3.0.7.src.js on lines 14617..14624

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function setState has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    setState: function (state) {
        var series = this,
            options = series.options,
            graph = series.graph,
            graphNeg = series.graphNeg,
Severity: Minor
Found in app/assets/javascripts/external/highcharts-3.0.7.src.js - About 1 hr to fix

    Function destroy has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        destroy: function () {
        var point = this,
            series = point.series,
            chart = series.chart,
            hoverPoints = chart.hoverPoints,
    Severity: Minor
    Found in app/assets/javascripts/external/highcharts-3.0.7.src.js - About 1 hr to fix

      Function pan has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          pan: function (e, panning) {

        var chart = this,
            hoverPoints = chart.hoverPoints,
            doRedraw;
      Severity: Minor
      Found in app/assets/javascripts/external/highcharts-3.0.7.src.js - About 1 hr to fix

        Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                render: function () {
            var values = this.values,
                target = this.target,
                regionShapes = this.regionShapes,
                shapes, ids, i, j;
        Severity: Minor
        Found in app/assets/javascripts/external/jquery.sparkline.js - About 1 hr to fix

          Function query has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                          opts.query = this.bind(function (query) {
                    var data = { results: [], more: false },
                        term = query.term,
                        children, firstChild, process;
          Severity: Minor
          Found in app/assets/javascripts/external/select2.js - About 1 hr to fix

            Function renderSlice has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    renderSlice: function (valuenum, highlight) {
            var target = this.target,
                options = this.options,
                radius = this.radius,
                borderWidth = options.get('borderWidth'),
            Severity: Minor
            Found in app/assets/javascripts/external/jquery.sparkline.js - About 1 hr to fix

              Function callback has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                                  callback: this.bind(function (data) {
                var def; // default choice

                // ignore a response if the select2 has been closed before it was received
                if (!this.opened()) return;
              Severity: Minor
              Found in app/assets/javascripts/external/select2.js - About 1 hr to fix

                Function renderRegion has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        renderRegion: function (valuenum, highlight) {
            var values = this.values,
                options = this.options,
                target = this.target,
                canvasHeight, height, halfHeight,
                Severity: Minor
                Found in app/assets/javascripts/external/jquery.sparkline.js - About 1 hr to fix

                  Function pinchTranslateDirection has 8 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      pinchTranslateDirection: function (horiz, pinchDown, touches, transform, selectionMarker, clip, lastValidTouch, forcedScale) {
                  Severity: Major
                  Found in app/assets/javascripts/external/highcharts-3.0.7.src.js - About 1 hr to fix

                    Function pinchTranslate has 8 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        pinchTranslate: function (zoomHor, zoomVert, pinchDown, touches, transform, selectionMarker, clip, lastValidTouch) {
                    Severity: Major
                    Found in app/assets/javascripts/external/highcharts-3.0.7.src.js - About 1 hr to fix

                      Consider simplifying this complex logical expression.
                      Open

                                  if (stacking && series.visible && stack && stack[xValue]) {

                pointStack = stack[xValue];
                stackValues = pointStack.points[series.index];
                yBottom = stackValues[0];
                      Severity: Major
                      Found in app/assets/javascripts/external/highcharts-3.0.7.src.js - About 1 hr to fix

                        Function getLabelPosition has 8 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            getLabelPosition: function (x, y, label, horiz, labelOptions, tickmarkOffset, index, step) {
                        Severity: Major
                        Found in app/assets/javascripts/external/highcharts-3.0.7.src.js - About 1 hr to fix

                          Function _drawPieSlice has 8 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  _drawPieSlice: function (shapeid, x, y, radius, startAngle, endAngle, lineColor, fillColor) {
                          Severity: Major
                          Found in app/assets/javascripts/external/jquery.sparkline.js - About 1 hr to fix

                            Function _drawPieSlice has 8 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    _drawPieSlice: function (shapeid, x, y, radius, startAngle, endAngle, lineColor, fillColor) {
                            Severity: Major
                            Found in app/assets/javascripts/external/jquery.sparkline.js - About 1 hr to fix

                              Method construct_conditions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  def construct_conditions
      if criterium.mapping and criterium.mapping.source != source
        # This is get Age at SHHS2 against SHHS1 (linked search)
        # GENERATE LINKED SQL
        # 1) Get the Source Join between criterium.mapping.source and source
                              Severity: Minor
                              Found in app/models/resolver.rb - About 55 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                              if strata_results_size > 0
                  body_row[index] = (include_html ? color_for_number((filtered_results.size.to_f / strata_results_size * 100), "#{(filtered_results.size.to_f / strata_results_size * 100).round(1)}%") : "#{(filtered_results.size.to_f / strata_results_size * 100).round(1)}%")
                else
                  body_row[index] = "---"
                              Severity: Minor
                              Found in app/models/report.rb and 1 other location - About 55 mins to fix
                              app/models/report.rb on lines 199..202

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                            if orig_results_size > 0
                body_row[index] = (include_html ? color_for_number((filtered_results.size.to_f / orig_results_size * 100), "#{(filtered_results.size.to_f / orig_results_size * 100).round(1)}%") : "#{(filtered_results.size.to_f / orig_results_size * 100).round(1)}%")
              else
                body_row[index] = "---"
                              Severity: Minor
                              Found in app/models/report.rb and 1 other location - About 55 mins to fix
                              app/models/report.rb on lines 208..211

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 45.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Method recent_activity has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                              Open

                                def recent_activity(past_time)
    return '' unless past_time.kind_of?(Time)
    time_ago_in_words(past_time)
    seconds_ago = (Time.now - past_time)
    color = if seconds_ago < 60.minute then "#6DD1EC"
                              Severity: Minor
                              Found in app/helpers/application_helper.rb - About 55 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method total_records_count has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                              Open

                                def total_records_count
    total_records_found = 0
    @overall_totals = {}
    @overall_errors = {}
                              Severity: Minor
                              Found in app/controllers/searches_controller.rb - About 55 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language