Sign upLogin

slovensko-digital/navody.digital

View on GitHub
Star
app/models/apps/parliament_vote_app/application_form.rb

Summary

Maintainability
D
2 days
Test Coverage
F
59%

Class ApplicationForm has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

    class ApplicationForm
      VOTE_DATE = Date.parse(ENV.fetch('APP_PARLIAMENT_VOTE_DATE', '2023-09-30'))
      DELIVERY_BY_POST_DEADLINE_DATE = Date.parse(ENV.fetch('APP_PARLIAMENT_DELIVERY_BY_POST_DEADLINE_DATE', '2023-09-08'))
      PICKUP_DEADLINE_DATE = Date.parse(ENV.fetch('APP_PARLIAMENT_PICKUP_DEADLINE_DATE', '2023-09-29'))
      VOTE_BY_POST_DEADLINE_DATE = Date.parse(ENV.fetch('APP_PARLIAMENT_VOTE_BY_POST_DEADLINE_DATE', '2023-08-09'))
Severity: Minor
Found in app/models/apps/parliament_vote_app/application_form.rb - About 4 hrs to fix

    File application_form.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Apps
  module ParliamentVoteApp
    class ApplicationForm
      VOTE_DATE = Date.parse(ENV.fetch('APP_PARLIAMENT_VOTE_DATE', '2023-09-30'))
      DELIVERY_BY_POST_DEADLINE_DATE = Date.parse(ENV.fetch('APP_PARLIAMENT_DELIVERY_BY_POST_DEADLINE_DATE', '2023-09-08'))
    Severity: Minor
    Found in app/models/apps/parliament_vote_app/application_form.rb - About 3 hrs to fix

      Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def run(listener)
        case step
        when 'start'
          start_step(listener)
        when 'place'
      Severity: Minor
      Found in app/models/apps/parliament_vote_app/application_form.rb - About 1 hr to fix

        Method pin_is_ok has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              private def pin_is_ok
        return errors.add(:pin, 'Rodné číslo je pocinná položka') if pin.blank?

        begin
          pin.to_i
        Severity: Minor
        Found in app/models/apps/parliament_vote_app/application_form.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                  return errors.add(:pin, 'Rodné číslo obsahuje neplatný mesiac')
        Severity: Major
        Found in app/models/apps/parliament_vote_app/application_form.rb - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                private def pin_is_ok
        return errors.add(:pin, 'Rodné číslo je pocinná položka') if pin.blank?

        begin
          pin.to_i
          Severity: Major
          Found in app/models/apps/parliament_vote_app/application_form.rb and 1 other location - About 3 hrs to fix
          app/models/apps/president_vote_app/application_form.rb on lines 154..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 113.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                private def delivery_step(listener)
        if go_back?
          self.step = 'place'
          listener.render :place
        elsif valid?(:delivery)
          Severity: Minor
          Found in app/models/apps/parliament_vote_app/application_form.rb and 1 other location - About 55 mins to fix
          app/models/apps/president_vote_app/application_form.rb on lines 282..299

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                private def sk_citizen_step(listener)
        if go_back?
          self.step = 'start'
          listener.render :start
        elsif valid?(:sk_citizen)
          Severity: Minor
          Found in app/models/apps/parliament_vote_app/application_form.rb and 2 other locations - About 40 mins to fix
          app/models/apps/president_vote_app/application_form.rb on lines 215..229
          app/models/apps/president_vote_app/application_form.rb on lines 232..246

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 37.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                private def delivery_address_step(listener)
        if go_back?
          self.step = 'identity'
          listener.render :identity
        elsif valid?(:delivery_address)
          Severity: Minor
          Found in app/models/apps/parliament_vote_app/application_form.rb and 5 other locations - About 15 mins to fix
          app/models/apps/parliament_vote_app/application_form.rb on lines 297..306
          app/models/apps/parliament_vote_app/application_form.rb on lines 333..342
          app/models/apps/parliament_vote_app/application_form.rb on lines 350..359
          app/models/apps/president_vote_app/application_form.rb on lines 302..311
          app/models/apps/president_vote_app/application_form.rb on lines 314..323

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                private def identity_step(listener)
        if go_back?
          self.step = 'delivery'
          listener.render :delivery
        elsif valid?(:identity)
          Severity: Minor
          Found in app/models/apps/parliament_vote_app/application_form.rb and 5 other locations - About 15 mins to fix
          app/models/apps/parliament_vote_app/application_form.rb on lines 309..318
          app/models/apps/parliament_vote_app/application_form.rb on lines 333..342
          app/models/apps/parliament_vote_app/application_form.rb on lines 350..359
          app/models/apps/president_vote_app/application_form.rb on lines 302..311
          app/models/apps/president_vote_app/application_form.rb on lines 314..323

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                private def world_sk_permanent_resident_step(listener)
        if go_back?
          self.step = 'place'
          listener.render :place
        elsif valid?(:world_sk_permanent_resident)
          Severity: Minor
          Found in app/models/apps/parliament_vote_app/application_form.rb and 5 other locations - About 15 mins to fix
          app/models/apps/parliament_vote_app/application_form.rb on lines 297..306
          app/models/apps/parliament_vote_app/application_form.rb on lines 309..318
          app/models/apps/parliament_vote_app/application_form.rb on lines 350..359
          app/models/apps/president_vote_app/application_form.rb on lines 302..311
          app/models/apps/president_vote_app/application_form.rb on lines 314..323

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                private def world_abroad_permanent_resident_step(listener)
        if go_back?
          self.step = 'permanent_resident'
          listener.render :permanent_resident
        elsif valid?(:world_abroad_permanent_resident)
          Severity: Minor
          Found in app/models/apps/parliament_vote_app/application_form.rb and 5 other locations - About 15 mins to fix
          app/models/apps/parliament_vote_app/application_form.rb on lines 297..306
          app/models/apps/parliament_vote_app/application_form.rb on lines 309..318
          app/models/apps/parliament_vote_app/application_form.rb on lines 333..342
          app/models/apps/president_vote_app/application_form.rb on lines 302..311
          app/models/apps/president_vote_app/application_form.rb on lines 314..323

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status