Sign upLogin

smart-io/php-3pl-central

View on GitHub
Star

Showing 7 of 7 total issues

OrderEntity has 89 functions (exceeds 20 allowed). Consider refactoring.
Open

class OrderEntity
{
    private $customerName;
    private $customerEmail;
    private $customerPhone;
Severity: Major
Found in src/Order/OrderEntity.php - About 1 day to fix

    File OrderEntity.php has 450 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace ThreePlCentral\Order;

class OrderEntity
    Severity: Minor
    Found in src/Order/OrderEntity.php - About 6 hrs to fix

      Method toArray has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function toArray()
    {
        return [
            'customerName' => $this->customerName,
            'customerEmail' => $this->customerEmail,
      Severity: Minor
      Found in src/Order/OrderEntity.php - About 1 hr to fix

        Function json has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function json()
    {
        $body = $this->body();
        $xml = new DOMDocument("1.0", "ISO-8859-15");
        $xml->loadXML($body);
        Severity: Minor
        Found in src/Response.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method findOrders has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function findOrders(ThreePlCentral $threepl, DateTime $beginDate, DateTime $endDate)
    {
        $request = RequestFactory::create(
            $threepl,
            'POST',
        Severity: Minor
        Found in src/Order/OrderRepository.php - About 1 hr to fix

          Function findOrders has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function findOrders(ThreePlCentral $threepl, DateTime $beginDate, DateTime $endDate)
    {
        $request = RequestFactory::create(
            $threepl,
            'POST',
          Severity: Minor
          Found in src/Order/OrderRepository.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function __construct($id, $customerId, $facilityId, $login, $password)
          Severity: Minor
          Found in src/ThreePlCentral.php - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language