Sign upLogin

smashingboxes/cardboard

View on GitHub
Star

Showing 29 of 29 total issues

Function createListReducer has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createListReducer(resource, resourceConfig) {
  const customReducer = resourceConfig.listReducer;
  // eg PROJECTS
  const actionPrefix = resource.toUpperCase();
Severity: Minor
Found in app/javascript/main/restfulApi/reducerCreators/SeamlessImmutable/createListReducer.js - About 1 hr to fix

    Function reducer has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function reducer(state = INITIAL_STATE, action) {
    switch (action.type) {
    case `${actionPrefix}_SHOW_START`:
    case `${actionPrefix}_CREATE_START`:
    case `${actionPrefix}_UPDATE_START`:
    Severity: Minor
    Found in app/javascript/main/restfulApi/reducerCreators/Immutable/createItemReducer.js - About 1 hr to fix

      Function createListReducer has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createListReducer(resource) {
  // eg PROJECTS
  const actionPrefix = resource.toUpperCase();

  const INITIAL_STATE = new Immutable.Map({
      Severity: Minor
      Found in app/javascript/main/restfulApi/reducerCreators/Immutable/createListReducer.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            case `${actionPrefix}_DELETE_SUCCESS`:
      return state.merge({
        isActive: false,
        isFetched: true,
        data: Immutable.from(action.payload.response)
        Severity: Major
        Found in app/javascript/main/restfulApi/reducerCreators/SeamlessImmutable/createItemReducer.js and 1 other location - About 1 hr to fix
        app/javascript/main/restfulApi/reducerCreators/SeamlessImmutable/createListReducer.js on lines 21..26

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            case `${actionPrefix}_LIST_SUCCESS`:
      return state.merge({
        isActive: false,
        isFetched: true,
        data: Immutable.from(action.payload.response)
        Severity: Major
        Found in app/javascript/main/restfulApi/reducerCreators/SeamlessImmutable/createListReducer.js and 1 other location - About 1 hr to fix
        app/javascript/main/restfulApi/reducerCreators/SeamlessImmutable/createItemReducer.js on lines 28..33

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          case 'show':
    return (id) => {
      return apiService
        .get(`/${resource}/${id}`)
        .then(({ data }) => data);
        Severity: Major
        Found in app/javascript/main/restfulApi/createService.js and 1 other location - About 1 hr to fix
        app/javascript/main/restfulApi/createService.js on lines 31..36

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          case 'delete':
    return (id) => {
      return apiService
        .delete(`/${resource}/${id}`)
        .then(({ data }) => data);
        Severity: Major
        Found in app/javascript/main/restfulApi/createService.js and 1 other location - About 1 hr to fix
        app/javascript/main/restfulApi/createService.js on lines 13..18

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            case `${actionPrefix}_DELETE_START`:
      return state.withMutations((map) => {
        map.delete('error');
        map.set('isActive', true);
      });
        Severity: Minor
        Found in app/javascript/main/restfulApi/reducerCreators/Immutable/createItemReducer.js and 1 other location - About 55 mins to fix
        app/javascript/main/restfulApi/reducerCreators/Immutable/createListReducer.js on lines 15..19

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            case `${actionPrefix}_LIST_START`:
      return state.withMutations((map) => {
        map.delete('error');
        map.set('isActive', true);
      });
        Severity: Minor
        Found in app/javascript/main/restfulApi/reducerCreators/Immutable/createListReducer.js and 1 other location - About 55 mins to fix
        app/javascript/main/restfulApi/reducerCreators/Immutable/createItemReducer.js on lines 19..23

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language