Sign upLogin

smok-serwis/coolamqp

View on GitHub
Star
coolamqp/uplink/listener/thread.py

Summary

Maintainability
A
1 hr
Test Coverage
C
70%

Function register has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def register(self, sock,  # type: socket.socket
Severity: Minor
Found in coolamqp/uplink/listener/thread.py - About 45 mins to fix

    Avoid too many return statements within this function.
    Open

        return EpollListener
    Severity: Major
    Found in coolamqp/uplink/listener/thread.py - About 30 mins to fix

      Line too long (88 > 80 characters)
      Open

              return SelectListener   # we're running on a platform that doesn't support epoll
      Severity: Minor
      Found in coolamqp/uplink/listener/thread.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (84 > 80 characters)
      Open

              super(ListenerThread, self).__init__(name=name or 'coolamqp/ListenerThread')
      Severity: Minor
      Found in coolamqp/uplink/listener/thread.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (97 > 80 characters)
      Open

      #        self._call_next_io_event.add(callable) - dummy that out, causes AssertionError to appear
      Severity: Minor
      Found in coolamqp/uplink/listener/thread.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      There are no issues that match your filters.

      Category
      Status