Sign upLogin

smok-serwis/smok-client

View on GitHub
Star
smok/threads/executor.py

Summary

Maintainability
A
2 hrs
Test Coverage
F
22%

Function process_orders has a Cognitive Complexity of 56 (exceeds 50 allowed). Consider refactoring.
Open

    def process_orders(self, orders) -> tp.List[Order]:
        """
        Do some orders and return those that need to be retried
        """
        futures_to_complete = []
Severity: Minor
Found in smok/threads/executor.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                            if not isinstance(fut, Future):
                                if fut is not None:
                                    pathpoint.set_new_value(time_ms(), fut)
                            else:
                                fut.add_done_callback(on_read_completed_factory(pathpoint))
Severity: Major
Found in smok/threads/executor.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status