Sign upLogin

snap-cloud/snapcon

View on GitHub
Star
app/models/event.rb

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Class Event has 36 methods (exceeds 20 allowed). Consider refactoring.
Open

class Event < ApplicationRecord
  include ActionView::Helpers::NumberHelper # for number_with_precision
  include ActionView::Helpers::SanitizeHelper
  include ActiveRecord::Transitions
  include RevisionCount
Severity: Minor
Found in app/models/event.rb - About 4 hrs to fix

    File event.rb has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Event < ApplicationRecord
  include ActionView::Helpers::NumberHelper # for number_with_precision
  include ActionView::Helpers::SanitizeHelper
  include ActiveRecord::Transitions
  include RevisionCount
    Severity: Minor
    Found in app/models/event.rb - About 2 hrs to fix

      Method update_state has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def update_state(transition, mail = false, subject = false, send_mail = false, send_mail_param)
      Severity: Minor
      Found in app/models/event.rb - About 35 mins to fix

        Method update_state has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def update_state(transition, mail = false, subject = false, send_mail = false, send_mail_param)
    alert = ''
    alert = 'Update Email Subject before Sending Mails' if mail && send_mail_param && subject && send_mail
    begin
      if mail
        Severity: Minor
        Found in app/models/event.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def process_acceptance(options)
    if program.conference.email_settings.send_on_accepted &&
       program.conference.email_settings.accepted_body &&
       program.conference.email_settings.accepted_subject &&
       options[:send_mail].present?
        Severity: Minor
        Found in app/models/event.rb and 1 other location - About 15 mins to fix
        app/models/event.rb on lines 248..254

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def process_rejection(options)
    if program.conference.email_settings.send_on_rejected &&
       program.conference.email_settings.rejected_body &&
       program.conference.email_settings.rejected_subject &&
       options[:send_mail].present?
        Severity: Minor
        Found in app/models/event.rb and 1 other location - About 15 mins to fix
        app/models/event.rb on lines 239..245

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status