Sign upLogin

snowplow/sluice

View on GitHub
Star

Showing 17 of 17 total issues

Method process_files has a Cognitive Complexity of 108 (exceeds 5 allowed). Consider refactoring.
Open

      def self.process_files(operation, s3, from_files_or_dir_or_loc, ignore=[], match_regex_or_glob='.+', to_loc_or_dir=nil, alter_filename_lambda=nil, flatten=false)

        # Validate that the file operation makes sense
        case operation
        when :copy, :move, :download, :upload
Severity: Minor
Found in lib/sluice/storage/s3/s3.rb - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_files has 151 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.process_files(operation, s3, from_files_or_dir_or_loc, ignore=[], match_regex_or_glob='.+', to_loc_or_dir=nil, alter_filename_lambda=nil, flatten=false)

        # Validate that the file operation makes sense
        case operation
        when :copy, :move, :download, :upload
Severity: Major
Found in lib/sluice/storage/s3/s3.rb - About 6 hrs to fix

    File s3.rb has 339 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'tmpdir'
require 'fog'
require 'thread'
require 'timeout'
    Severity: Minor
    Found in lib/sluice/storage/s3/s3.rb - About 4 hrs to fix

      Method process_files has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def self.process_files(operation, s3, from_files_or_dir_or_loc, ignore=[], match_regex_or_glob='.+', to_loc_or_dir=nil, alter_filename_lambda=nil, flatten=false)
      Severity: Major
      Found in lib/sluice/storage/s3/s3.rb - About 1 hr to fix

        Method name_file has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def self.name_file(filepath, new_filename, remove_path=nil, add_path=nil, flatten=false)

        # First, replace the filename in filepath with new one
        dirname = File.dirname(filepath)
        new_filepath = (dirname == '.') ? new_filename : dirname + '/' + new_filename
        Severity: Minor
        Found in lib/sluice/storage/s3/s3.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method copy_files_inter has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def self.copy_files_inter(from_s3, to_s3, from_location, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)
        Severity: Major
        Found in lib/sluice/storage/s3/s3.rb - About 50 mins to fix

          Method copy_files_manifest has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def self.copy_files_manifest(s3, manifest, from_files_or_loc, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)
          Severity: Major
          Found in lib/sluice/storage/s3/s3.rb - About 50 mins to fix

            Method move_files_inter has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def self.move_files_inter(from_s3, to_s3, from_location, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)
            Severity: Major
            Found in lib/sluice/storage/s3/s3.rb - About 50 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                    if files_to_process.size == 0
                        complete = true
                        next
                      else
                        marker_opts['marker'] = files_to_process.last.key
              Severity: Major
              Found in lib/sluice/storage/s3/s3.rb - About 45 mins to fix

                Method copy_files has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def self.copy_files(s3, from_files_or_loc, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)
                Severity: Minor
                Found in lib/sluice/storage/s3/s3.rb - About 45 mins to fix

                  Method move_files has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def self.move_files(s3, from_files_or_loc, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)
                  Severity: Minor
                  Found in lib/sluice/storage/s3/s3.rb - About 45 mins to fix

                    Method name_file has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          def self.name_file(filepath, new_filename, remove_path=nil, add_path=nil, flatten=false)
                    Severity: Minor
                    Found in lib/sluice/storage/s3/s3.rb - About 35 mins to fix

                      Method retry_x has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            def self.retry_x(object, send_args, retries, attempt_msg, failure_msg)
                      Severity: Minor
                      Found in lib/sluice/storage/s3/s3.rb - About 35 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                      when :copy
                source = "#{from_bucket}/#{filepath}"
                target = name_file(filepath, filename, from_path, to_loc_or_dir.dir_as_path, flatten)
                puts "(t#{thread_idx})    COPY #{source} +-> #{to_loc_or_dir.bucket}/#{target}"
                        Severity: Minor
                        Found in lib/sluice/storage/s3/s3.rb and 1 other location - About 30 mins to fix
                        lib/sluice/storage/s3/s3.rb on lines 507..510

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 32.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                      when :move
                source = "#{from_bucket}/#{filepath}"
                target = name_file(filepath, filename, from_path, to_loc_or_dir.dir_as_path, flatten)
                puts "(t#{thread_idx})    MOVE #{source} -> #{to_loc_or_dir.bucket}/#{target}"
                        Severity: Minor
                        Found in lib/sluice/storage/s3/s3.rb and 1 other location - About 30 mins to fix
                        lib/sluice/storage/s3/s3.rb on lines 511..514

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 32.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              def self.move_files(s3, from_files_or_loc, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)

        puts "  moving #{describe_from(from_files_or_loc)} to #{to_location}"
        process_files(:move, s3, from_files_or_loc, [], match_regex, to_location, alter_filename_lambda, flatten)
                        Severity: Minor
                        Found in lib/sluice/storage/s3/s3.rb and 1 other location - About 15 mins to fix
                        lib/sluice/storage/s3/s3.rb on lines 198..201

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              def self.copy_files(s3, from_files_or_loc, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)

        puts "  copying #{describe_from(from_files_or_loc)} to #{to_location}"
        process_files(:copy, s3, from_files_or_loc, [], match_regex, to_location, alter_filename_lambda, flatten)
                        Severity: Minor
                        Found in lib/sluice/storage/s3/s3.rb and 1 other location - About 15 mins to fix
                        lib/sluice/storage/s3/s3.rb on lines 270..273

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language