Sign upLogin

snowplow/sluice

View on GitHub
Star

Showing 13 of 17 total issues

Method process_files has a Cognitive Complexity of 108 (exceeds 5 allowed). Consider refactoring.
Open

      def self.process_files(operation, s3, from_files_or_dir_or_loc, ignore=[], match_regex_or_glob='.+', to_loc_or_dir=nil, alter_filename_lambda=nil, flatten=false)

        # Validate that the file operation makes sense
        case operation
        when :copy, :move, :download, :upload
Severity: Minor
Found in lib/sluice/storage/s3/s3.rb - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_files has 151 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.process_files(operation, s3, from_files_or_dir_or_loc, ignore=[], match_regex_or_glob='.+', to_loc_or_dir=nil, alter_filename_lambda=nil, flatten=false)

        # Validate that the file operation makes sense
        case operation
        when :copy, :move, :download, :upload
Severity: Major
Found in lib/sluice/storage/s3/s3.rb - About 6 hrs to fix

    File s3.rb has 339 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'tmpdir'
require 'fog'
require 'thread'
require 'timeout'
    Severity: Minor
    Found in lib/sluice/storage/s3/s3.rb - About 4 hrs to fix

      Method process_files has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def self.process_files(operation, s3, from_files_or_dir_or_loc, ignore=[], match_regex_or_glob='.+', to_loc_or_dir=nil, alter_filename_lambda=nil, flatten=false)
      Severity: Major
      Found in lib/sluice/storage/s3/s3.rb - About 1 hr to fix

        Method name_file has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def self.name_file(filepath, new_filename, remove_path=nil, add_path=nil, flatten=false)

        # First, replace the filename in filepath with new one
        dirname = File.dirname(filepath)
        new_filepath = (dirname == '.') ? new_filename : dirname + '/' + new_filename
        Severity: Minor
        Found in lib/sluice/storage/s3/s3.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method copy_files_inter has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def self.copy_files_inter(from_s3, to_s3, from_location, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)
        Severity: Major
        Found in lib/sluice/storage/s3/s3.rb - About 50 mins to fix

          Method copy_files_manifest has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def self.copy_files_manifest(s3, manifest, from_files_or_loc, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)
          Severity: Major
          Found in lib/sluice/storage/s3/s3.rb - About 50 mins to fix

            Method move_files_inter has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def self.move_files_inter(from_s3, to_s3, from_location, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)
            Severity: Major
            Found in lib/sluice/storage/s3/s3.rb - About 50 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                    if files_to_process.size == 0
                        complete = true
                        next
                      else
                        marker_opts['marker'] = files_to_process.last.key
              Severity: Major
              Found in lib/sluice/storage/s3/s3.rb - About 45 mins to fix

                Method copy_files has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def self.copy_files(s3, from_files_or_loc, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)
                Severity: Minor
                Found in lib/sluice/storage/s3/s3.rb - About 45 mins to fix

                  Method move_files has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        def self.move_files(s3, from_files_or_loc, to_location, match_regex='.+', alter_filename_lambda=nil, flatten=false)
                  Severity: Minor
                  Found in lib/sluice/storage/s3/s3.rb - About 45 mins to fix

                    Method name_file has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          def self.name_file(filepath, new_filename, remove_path=nil, add_path=nil, flatten=false)
                    Severity: Minor
                    Found in lib/sluice/storage/s3/s3.rb - About 35 mins to fix

                      Method retry_x has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            def self.retry_x(object, send_args, retries, attempt_msg, failure_msg)
                      Severity: Minor
                      Found in lib/sluice/storage/s3/s3.rb - About 35 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language