snowplow/snowplow-javascript-tracker

View on GitHub
libraries/browser-tracker-core/src/tracker/cookie_storage.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function newCookie has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function newCookie(name: string): Cookie {
  let flushTimer: ReturnType<typeof setTimeout> | undefined;
  let lastSetValueArgs: Parameters<typeof setValue> | undefined;
  let cacheExpireAt: Date | undefined;
  let flushed = true;
Severity: Major
Found in libraries/browser-tracker-core/src/tracker/cookie_storage.ts - About 2 hrs to fix

    Function newCookie has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    function newCookie(name: string): Cookie {
      let flushTimer: ReturnType<typeof setTimeout> | undefined;
      let lastSetValueArgs: Parameters<typeof setValue> | undefined;
      let cacheExpireAt: Date | undefined;
      let flushed = true;
    Severity: Minor
    Found in libraries/browser-tracker-core/src/tracker/cookie_storage.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function newCookieStorage has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function newCookieStorage(): AsyncCookieStorage {
      let cache: Record<string, Cookie> = {};
    
      function getOrInitCookie(name: string): Cookie {
        if (!cache[name]) {
    Severity: Minor
    Found in libraries/browser-tracker-core/src/tracker/cookie_storage.ts - About 1 hr to fix

      Function setCookie has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          name: string,
          value?: string,
          ttl?: number,
          path?: string,
          domain?: string,
      Severity: Major
      Found in libraries/browser-tracker-core/src/tracker/cookie_storage.ts - About 50 mins to fix

        Function setValue has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          function setValue(value?: string, ttl?: number, path?: string, domain?: string, samesite?: string, secure?: boolean): boolean {
        Severity: Minor
        Found in libraries/browser-tracker-core/src/tracker/cookie_storage.ts - About 45 mins to fix

          Function deleteCookie has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            function deleteCookie(name: string, path?: string, domainName?: string, sameSite?: string, secure?: boolean): void {
          Severity: Minor
          Found in libraries/browser-tracker-core/src/tracker/cookie_storage.ts - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status