Sign upLogin

snowplow/snowplow-javascript-tracker

View on GitHub
Star
plugins/browser-plugin-media-tracking/src/findMediaElement.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function findMediaElementChild has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

function findMediaElementChild(el: Element): SearchResult {
  for (let tag of Object.keys(TAG)) {
    let elem = el.getElementsByTagName(tag);
    if (elem.length === 1) {
      if (isAudioElement(elem[0])) return { el: elem[0] };
Severity: Minor
Found in plugins/browser-plugin-media-tracking/src/findMediaElement.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  return findMediaElementChild(el);
Severity: Major
Found in plugins/browser-plugin-media-tracking/src/findMediaElement.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return { err: SEARCH_ERROR.NOT_FOUND };
    Severity: Major
    Found in plugins/browser-plugin-media-tracking/src/findMediaElement.ts - About 30 mins to fix

      Function findMediaElem has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export function findMediaElem(id: string): SearchResult {
  let el: HTMLVideoElement | HTMLAudioElement | HTMLElement | null = document.getElementById(id);

  if (!el) return { err: SEARCH_ERROR.NOT_FOUND };
  if (isAudioElement(el)) return { el: el };
      Severity: Minor
      Found in plugins/browser-plugin-media-tracking/src/findMediaElement.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status