Sign upLogin

so5/sbs

View on GitHub
Star

Showing 13 of 13 total issues

Function _dispatch has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

  async _dispatch () {
    // to go or not to go
    if (this.queue.size() <= 0) {
      debug(this.name, "queue is empty");
Severity: Minor
Found in lib/index.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File index.js has 315 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";
const { EventEmitter } = require("events");
const { validate: validateUUID } = require("uuid");
const debug = require("debug")("sbs:sbs");
const Queue = require("./fifo");
Severity: Minor
Found in lib/index.js - About 3 hrs to fix

    Function _dispatch has 81 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async _dispatch () {
    // to go or not to go
    if (this.queue.size() <= 0) {
      debug(this.name, "queue is empty");
    Severity: Major
    Found in lib/index.js - About 3 hrs to fix

      Function constructor has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor (opt = {}) {
    super();
    this.maxConcurrent = sanitizeNumber(opt.maxConcurrent, 1, null, 1);
    this.exec = typeof opt.exec === "function" ? opt.exec : null;
    this.retry = opt.retry;
      Severity: Minor
      Found in lib/index.js - About 1 hr to fix

        Function _qsub has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _qsub (job, urgent) {
    if (typeof this.exec !== "function" && typeof job !== "function" && typeof job.exec !== "function") {
      debug(this.name, "no function specified");
      return null;
    }
        Severity: Minor
        Found in lib/index.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (this.failed.has(id)) {
      rt = this.failed.get(id);

      if (!(this.noAutoClear || keepResult)) {
        this.failed.set(id, null);
          Severity: Major
          Found in lib/index.js and 1 other location - About 1 hr to fix
          lib/index.js on lines 348..354

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              } else if (this.finished.has(id)) {
      rt = this.finished.get(id);

      if (!(this.noAutoClear || keepResult)) {
        this.finished.set(id, null);
          Severity: Major
          Found in lib/index.js and 1 other location - About 1 hr to fix
          lib/index.js on lines 342..354

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function sanitizeNumber has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          function sanitizeNumber (num, min, max, def) {
  let rt = def;
  if (typeof num === "string") {
    rt = parseFloat(num);
  }
          Severity: Minor
          Found in lib/index.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function qsub has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            qsub (job, urgent = false) {
    if (this.submitHook) {
      const rt = this.submitHook(this.queue, job, urgent);
      if (rt instanceof Promise || (rt && typeof rt.then === "function")) {
        // submitHook is async, _qsub() will be called after submitHook() is fullfilled
          Severity: Minor
          Found in lib/index.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getResult has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            getResult (id, keepResult) {
    let rt = null;
    if (this.failed.has(id)) {
      rt = this.failed.get(id);
          Severity: Minor
          Found in lib/index.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _qsub has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            _qsub (job, urgent) {
    if (typeof this.exec !== "function" && typeof job !== "function" && typeof job.exec !== "function") {
      debug(this.name, "no function specified");
      return null;
    }
          Severity: Minor
          Found in lib/index.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function clear has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            clear () {
    this.stop();
    this.queue.clear();
    this.finished.clear();
    this.failed.clear();
          Severity: Minor
          Found in lib/index.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            constructor (opt = {}) {
    super();
    this.maxConcurrent = sanitizeNumber(opt.maxConcurrent, 1, null, 1);
    this.exec = typeof opt.exec === "function" ? opt.exec : null;
    this.retry = opt.retry;
          Severity: Minor
          Found in lib/index.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language