Sign upLogin

socialcast/link_preview

View on GitHub
Star

Showing 7 of 7 total issues

Class Content has 45 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Content
    PROPERTIES = [
      :title,
      :description,
      :site_name,
Severity: Minor
Found in lib/link_preview/content.rb - About 6 hrs to fix

    File content.rb has 323 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'link_preview/uri'
require 'link_preview/parser'
require 'link_preview/http_crawler'
require 'link_preview/null_crawler'
    Severity: Minor
    Found in lib/link_preview/content.rb - About 3 hrs to fix

      Class Parser has 27 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Parser
    attr_accessor :discovered_uris

    def initialize(config, options = {})
      @config = config
      Severity: Minor
      Found in lib/link_preview/parser.rb - About 3 hrs to fix

        Method valid_meta_node? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def valid_meta_node?(node)
      return false unless node
      return false unless node.respond_to?(:attributes)
      return false unless node.attributes['content']
      return false unless node.attributes['content'].value
        Severity: Minor
        Found in lib/link_preview/parser.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method matching_meta_pair? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def matching_meta_pair?(node, key, value)
      return false unless valid_meta_node?(node)
      return false unless node.attributes[key]
      return false unless node.attributes[key].value
      return false unless matching_meta_value?(node, key, value)
        Severity: Minor
        Found in lib/link_preview/parser.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method update_env has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def update_env(env, request_body, response)
      env[:url] += response['location']
      if @options[:cookies]
        cookies = keep_cookies(env)
        env[:request_headers][:cookies] = cookies unless cookies.nil?
        Severity: Minor
        Found in lib/faraday/follow_redirects.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method perform_with_redirection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def perform_with_redirection(env, follows)
      request_body = env[:body]
      response = @app.call(env)

      response.on_complete do |response_env|
        Severity: Minor
        Found in lib/faraday/follow_redirects.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language