Sign upLogin

sockethub/sockethub

View on GitHub
Star
packages/activity-streams/src/activity-streams.ts

Summary

Maintainability
A
0 mins
Test Coverage

Function expandStream has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Invalid

function expandStream(meta) {
    const stream = {};
    for (const key of Object.keys(meta)) {
        if (typeof meta[key] === "string") {
            stream[key] = objs.get(meta[key]) || meta[key];
Severity: Minor
Found in packages/activity-streams/src/activity-streams.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateObject has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Invalid

function validateObject(type, obj: ActivityObject = { type: "" }) {
    const unknownKeys = Object.keys(obj).filter((key): void | string => {
        if (!baseProps[type].includes(key)) {
            return key;
        }
Severity: Minor
Found in packages/activity-streams/src/activity-streams.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ASFactory has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

export default function ASFactory(opts: ASFactoryOptions = {}): ASManager {
    specialObjs = opts?.specialObjs || [];
    failOnUnknownObjectProperties =
        typeof opts.failOnUnknownObjectProperties === "boolean"
            ? opts.failOnUnknownObjectProperties
Severity: Minor
Found in packages/activity-streams/src/activity-streams.ts - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status